Skip to content

Fix/skill template #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qin-ctx merged 1 commit into from
May 11, 2026
+6 −4
Merged

Fix/skill template #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openviking/prompts/templates/memory/skills.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ enabled: true
content_template: |
Skill: {{ skill_name }}

- Success rate: {{ ((success_count|default(0) / (total_executions|default(1) if total_executions|default(0) > 0 else 1)) * 100)|round|int }}% ({{ success_count|default(0) }}/{{ total_executions|default(0) }})
- Success rate: {{ ((success_count|default(0, true) / (total_executions|default(1, true) if total_executions|default(0, true) > 0 else 1)) * 100)|round|int }}% ({{ success_count|default(0, true) }}/{{ total_executions|default(0, true) }})
- Best for: {{ best_for|default('N/A') }}
- Recommended flow: {{ recommended_flow|default('N/A') }}
- Key dependencies: {{ key_dependencies|default('N/A') }}
Expand Down
8 changes: 5 additions & 3 deletions openviking/session/memory/utils/content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ def serialize_with_metadata(

jinja_template = env.from_string(content_template)
content = jinja_template.render(**template_vars).strip()
except Exception:
# If template rendering fails, use content as-is
pass
except Exception as e:
from openviking.telemetry import tracer

tracer.error(f"Template rendering failed, skipping write: {e}")
raise

# Clean metadata - remove None values and memory_type
clean_metadata = {k: v for k, v in metadata.items() if v is not None and k != "memory_type"}
Expand Down
Loading