You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normalize transcript turn text identically to the last assistant message before hashing to ensure consistent duplicate detection. Extract text normalization into a shared helper to avoid logic duplication.
Why: The suggestion fixes inconsistent text normalization between the last assistant message and transcript turns, which would cause incorrect duplicate detection. Extracting normalizeText ensures hashes are computed identically, improving correctness.
Medium
General
Use strict equality for turn count check
Use strict equality check instead of greater-or-equal to verify all new transcript turns were appended, as added should never exceed newTurns.length. This avoids false positives if added unexpectedly exceeds newTurns.length.
Why: Using strict equality instead of >= is a defensive check that avoids false positives if added unexpectedly exceeds newTurns.length, improving code robustness.
Closing this PR because it was based on the wrong interpretation of task #103. The requested MCP validation should target OpenViking's native /mcp endpoint, not the example Codex memory plugin's small helper MCP server. I will re-test against the native endpoint and open a focused PR only if that path has an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_assistant_messageon Stop whencaptureLastAssistantOnStop=trueVerification
npm run buildinexamples/codex-memory-pluginnode --check examples/codex-memory-plugin/scripts/auto-capture.mjsnode --check examples/codex-memory-plugin/scripts/session-state.mjsgit diff --checklast_assistant_message, repeat Stop no-op, PreCompact commit preserved stateopenviking_health,openviking_store,openviking_recallhookSpecificOutput.additionalContextcontaining the stored marker memory