Skip to content

fix(storage): detect overview language from child summaries#2054

Merged
zhoujh01 merged 1 commit into
mainfrom
fix/semantic-overview-language
May 14, 2026
Merged

fix(storage): detect overview language from child summaries#2054
zhoujh01 merged 1 commit into
mainfrom
fix/semantic-overview-language

Conversation

@qin-ctx
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx commented May 14, 2026

Description

Fix directory overview language detection for resource directories that contain only child directories. The semantic processor now considers child directory abstracts when resolving the output language, so Chinese-only directory trees do not fall back to English just because there are no direct file summaries.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Include child directory abstracts in overview output-language detection.
  • Keep file summaries as the primary detection source when present.
  • Fall back to the directory name only when neither files nor child summaries exist.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Command run:

.venv/bin/python -m pytest tests/storage/test_semantic_processor_language.py

Result: 33 passed, 4 existing warnings.

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

This PR intentionally keeps the fix scoped to semantic_processor.py only.

@zhoujh01 zhoujh01 merged commit fa1e9f9 into main May 14, 2026
5 checks passed
@zhoujh01 zhoujh01 deleted the fix/semantic-overview-language branch May 14, 2026 13:36
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 14, 2026
@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants