feat(storage): add Milvus vector adapter#3041
Open
zc277584121 wants to merge 2 commits into
Open
Conversation
7fc8c89 to
0148ffc
Compare
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
782b00c to
4871c23
Compare
Author
|
Hi @qin-ctx @ZaynJarvis, could you take a look when you have a chance? This PR adds a Milvus vector database adapter using the existing CollectionAdapter/factory structure. The branch has been rebased on the latest main and is mergeable again. Focused local checks are passing: py_compile, ruff check, ruff format --check, uv lock --check, and git diff --check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
uvx ruff format --check openviking/storage/vectordb_adapters/milvus_adapter.py tests/storage/test_milvus_adapter.py openviking_cli/utils/config/vectordb_config.pyuvx ruff check openviking/storage/vectordb_adapters/milvus_adapter.py tests/storage/test_milvus_adapter.py openviking/storage/vectordb_adapters/factory.py openviking/storage/vectordb_adapters/__init__.py openviking_cli/utils/config/vectordb_config.pypython3.10 -m py_compile openviking/storage/vectordb_adapters/milvus_adapter.py tests/storage/test_milvus_adapter.py openviking_cli/utils/config/vectordb_config.pygit diff --check origin/main...HEADuv lock --checkPYTHONPATH=. uv run --no-project --python 3.10 --with pytest --with pydantic --with typing-extensions --with pyyaml --with httpx --with loguru --with 'pymilvus[milvus_lite]' --with apscheduler --with json-repair --with xxhash --with volcengine pytest --confcutdir=tests/storage -o addopts= tests/storage/test_milvus_adapter.py -q