fix(bot): keep memory-commit side effects out of the LLM-visible answer loop#3087
Open
r266-tech wants to merge 1 commit into
Open
fix(bot): keep memory-commit side effects out of the LLM-visible answer loop#3087r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3082.
Summary
openviking_memory_commitas a side-effect tool in the agent loop.tools_used/logs, but do not add its tool result to the LLM-visible reflection transcript.Notes
tools_usedstill retains the memory commit call/result for traceability, matching the issue's expectation that side effects remain recorded outside the LLM transcript.Verification
/tmp/ov-3082-venv/bin/python -m py_compile bot/vikingbot/agent/loop.py bot/tests/test_agent_loop_outcome.pygit diff --check/tmp/ov-3082-venv/bin/python -m pytest bot/tests/test_agent_loop_outcome.py -qdid not reach test collection in this sparse local checkout becausebot/tests/conftest.pyimports the full OpenViking service stack and the local venv is missing the declaredvolcengineSDK dependency.