fix(bot): add missing sender_name param in Slack and Email channels#3104
Open
scott-kim-7 wants to merge 1 commit into
Open
fix(bot): add missing sender_name param in Slack and Email channels#3104scott-kim-7 wants to merge 1 commit into
scott-kim-7 wants to merge 1 commit into
Conversation
Commit 4d34025 added the required `sender_name` parameter to `BaseChannel._handle_message()` and updated `feishu.py`, but `slack.py` and `email.py` were not updated in the same change. This caused a `TypeError` on every inbound message in both channels. Because Slack SDK swallows exceptions in asyncio listener callbacks, the error was silent — the bot received events, added emoji reactions, but never called the LLM or sent any reply. Fix: pass `sender_name=sender_id` in SlackChannel and `sender_name=sender` in EmailChannel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commit
4d34025c("feat(bot):enhance Feishu mentions and name display") added a requiredsender_name: strparameter toBaseChannel._handle_message()and updatedfeishu.py, butslack.pyandemail.pywere not updated in the same commit.This causes a
TypeErroron every inbound message in both channels:Because the Slack SDK swallows exceptions raised inside asyncio listener callbacks, the error is completely silent — the bot successfully receives events and adds emoji reactions (👀), but never calls the LLM or sends any reply.
The same issue affects
EmailChannel: every polled email triggers aTypeErrorwith no response sent.Fix
Pass the missing argument in both callers:
SlackChannel._on_socket_request:sender_name=sender_idEmailChannel.start:sender_name=senderTesting
git show 4d34025c --name-onlyconfirms onlybase.pyandfeishu.pywere modified, notslack.pyoremail.py