From 21446a480871f209b68ea33882d59d7f93adaf6c Mon Sep 17 00:00:00 2001 From: "scott.kim" Date: Fri, 10 Jul 2026 00:02:57 +0900 Subject: [PATCH] fix(bot): add missing sender_name param in Slack and Email channels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 4d34025c added the required `sender_name` parameter to `BaseChannel._handle_message()` and updated `feishu.py`, but `slack.py` and `email.py` were not updated in the same change. This caused a `TypeError` on every inbound message in both channels. Because Slack SDK swallows exceptions in asyncio listener callbacks, the error was silent — the bot received events, added emoji reactions, but never called the LLM or sent any reply. Fix: pass `sender_name=sender_id` in SlackChannel and `sender_name=sender` in EmailChannel. Co-Authored-By: Claude Sonnet 4.6 --- bot/vikingbot/channels/email.py | 1 + bot/vikingbot/channels/slack.py | 1 + 2 files changed, 2 insertions(+) diff --git a/bot/vikingbot/channels/email.py b/bot/vikingbot/channels/email.py index 8e5eaa4f11..83c5671885 100644 --- a/bot/vikingbot/channels/email.py +++ b/bot/vikingbot/channels/email.py @@ -89,6 +89,7 @@ async def start(self) -> None: await self._handle_message( sender_id=sender, + sender_name=sender, chat_id=sender, content=item["content"], metadata=item.get("metadata", {}), diff --git a/bot/vikingbot/channels/slack.py b/bot/vikingbot/channels/slack.py index e8744afbce..9163bf1af3 100644 --- a/bot/vikingbot/channels/slack.py +++ b/bot/vikingbot/channels/slack.py @@ -167,6 +167,7 @@ async def _on_socket_request( await self._handle_message( sender_id=sender_id, + sender_name=sender_id, chat_id=chat_id, content=text, metadata={