refining

Author: voltsparx

lib/asrfacet_rb/output/base_formatter.rb

@@ -153,7 +153,8 @@ def recommendations_for(payload)
         recommendations << "Review the fault-isolation notes before trusting the run as complete, because one or more engines degraded or were skipped."
       end
 
-      if integrity_report(payload)[:status].to_s != "ok"
+      integrity_status = integrity_report(payload)[:status].to_s
+      if %w[warning critical].include?(integrity_status)
         recommendations << "Resolve the framework integrity findings before the next run so missing files or write-path issues do not distort results."
       end
 

spec/output/cli_formatter_spec.rb

@@ -44,4 +44,23 @@
       expect(output).to include("Scan Overview", "Subdomains", "HTTP Exposure")
     end.not_to output(/currently set width|vertical orientation/i).to_stderr
   end
+
+  it "does not recommend integrity remediation when no integrity status is present" do
+    formatter = described_class.new
+    store = ASRFacet::ResultStore.new
+    store.add(:subdomains, "scanme.nmap.org")
+
+    payload = {
+      store: store,
+      top_assets: [],
+      summary: store.summary,
+      meta: {
+        generated_at: Time.now.utc.iso8601,
+        output_directory: "C:/tmp/asrfacet"
+      }
+    }
+
+    output = formatter.format(payload)
+    expect(output).not_to include("Resolve the framework integrity findings before the next run")
+  end
 end