perf: improve task management behavior

Author: voocel

internal/agent/events.go

@@ -12,6 +12,7 @@ const (
 	ReminderRepeatToolCall     RuntimeReminderKind = "repeat_tool_call"
 	ReminderPostStopValidation RuntimeReminderKind = "post_stop_validation"
 	ReminderSkillPaths         RuntimeReminderKind = "skill_paths"
+	ReminderTaskManagement     RuntimeReminderKind = "task_management"
 )
 
 type CompactionKind string

internal/agent/runtime_policy.go

@@ -46,7 +46,14 @@ func newSessionRuntimePolicy(session *Session) *sessionRuntimePolicy {
 	return &sessionRuntimePolicy{session: session}
 }
 
-func (p *sessionRuntimePolicy) beforePrompt() {
+func (p *sessionRuntimePolicy) beforeUserPrompt(blocks []agentcore.ContentBlock) {
+	if reminder, ok := taskManagementReminderForPrompt(blocks, p.session.TaskSnapshot()); ok {
+		p.session.queueRuntimeReminder(
+			"task_management:pre_prompt",
+			ReminderTaskManagement,
+			reminder,
+		)
+	}
 }
 
 func (p *sessionRuntimePolicy) handleEvent(ev agentcore.Event) {
@@ -107,6 +114,7 @@ func (p *sessionRuntimePolicy) trackToolEnd(ev agentcore.Event) {
 	p.session.mu.Unlock()
 
 	p.detectRepeatedCalls(record, recent)
+	p.detectTaskManagementGap()
 }
 
 func (p *sessionRuntimePolicy) detectRepeatedCalls(current toolCallFingerprint, recent []toolCallFingerprint) {
@@ -127,7 +135,27 @@ func (p *sessionRuntimePolicy) detectRepeatedCalls(current toolCallFingerprint,
 		p.session.deliverRuntimeReminder(
 			"repeat_tool_call:"+current.Tool+":"+current.ArgsHash,
 			ReminderRepeatToolCall,
-			"<system-reminder>\n检测到你在重复调用同一个工具且参数基本相同。先总结当前已知信息、差距和下一步假设；避免在没有新信息时继续相同调用。\n</system-reminder>",
+			"<system-reminder>\nYou are repeatedly calling the same tool with effectively the same arguments. Summarize what you already know, what is still missing, and your next hypothesis before making the same call again.\n</system-reminder>",
+		)
+	}
+}
+
+func (p *sessionRuntimePolicy) detectTaskManagementGap() {
+	s := p.session
+	if s.taskStore == nil {
+		return
+	}
+
+	s.mu.Lock()
+	turn := s.currentTurn
+	s.mu.Unlock()
+
+	snap := s.taskStore.Snapshot()
+	if key, reminder, ok := taskManagementReminderForTurn(turn, snap); ok {
+		p.session.deliverRuntimeReminder(
+			key,
+			ReminderTaskManagement,
+			reminder,
 		)
 	}
 }
@@ -317,7 +345,7 @@ func (p *sessionRuntimePolicy) runPostStopValidation() {
 			"post_stop_validation",
 			ReminderPostStopValidation,
 			fmt.Sprintf(
-				"<system-reminder>\nPostStopValidation hook 检查失败，请根据以下输出修复问题：\n%s\n</system-reminder>",
+				"<system-reminder>\nThe PostStopValidation hook failed. Fix the problem based on the following output:\n%s\n</system-reminder>",
 				failOutput,
 			),
 		)

internal/agent/session.go

@@ -215,6 +215,13 @@ func (s *Session) TaskSnapshot() localtools.TaskSnapshot {
 	return s.taskStore.Snapshot()
 }
 
+func (s *Session) ResetTaskList() error {
+	if s.taskStore == nil {
+		return nil
+	}
+	return s.taskStore.Reset()
+}
+
 func (s *Session) resetHarnessStateLocked() {
 	s.generation++
 	s.runtimeReminders = nil

internal/agent/session_runtime.go

@@ -22,7 +22,7 @@ func (s *Session) Prompt(text string) error {
 		s.beforePrompt()
 	}
 	if s.runtime != nil {
-		s.runtime.beforePrompt()
+		s.runtime.beforeUserPrompt([]agentcore.ContentBlock{agentcore.TextBlock(text)})
 	}
 
 	var msgs []agentcore.AgentMessage
@@ -40,7 +40,7 @@ func (s *Session) PromptWithBlocks(blocks []agentcore.ContentBlock) error {
 		s.beforePrompt()
 	}
 	if s.runtime != nil {
-		s.runtime.beforePrompt()
+		s.runtime.beforeUserPrompt(blocks)
 	}
 
 	var msgs []agentcore.AgentMessage

internal/agent/session_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"strings"
 	"sync"
 	"testing"
@@ -14,6 +15,7 @@ import (
 	"github.com/voocel/codebot/internal/config"
 	"github.com/voocel/codebot/internal/skill"
 	"github.com/voocel/codebot/internal/storage"
+	localtools "github.com/voocel/codebot/internal/tools"
 )
 
 type stubChatModel struct{}
@@ -93,7 +95,7 @@ func (m *scriptedReminderModel) Generate(
 		if msg.Role == agentcore.RoleUser && strings.Contains(msg.TextContent(), "<system-reminder>") {
 			sawInjectedReminder = true
 		}
-		if msg.Role == agentcore.RoleUser && strings.Contains(msg.TextContent(), "重复调用同一个工具") {
+		if msg.Role == agentcore.RoleUser && strings.Contains(msg.TextContent(), "repeatedly calling the same tool") {
 			m.secondCallSawReminder = true
 		}
 	}
@@ -597,16 +599,16 @@ func TestBuildUserMessagePrependsRuntimeRemindersBeforeStaticReminders(t *testin
 		Agent:     ag,
 		Settings:  config.Resolved{MaxTurns: 30},
 		Cwd:       t.TempDir(),
-		Reminders: []string{"<system-reminder>\n静态提醒\n</system-reminder>"},
+		Reminders: []string{"<system-reminder>\nstatic reminder\n</system-reminder>"},
 	})
 	t.Cleanup(s.Close)
 
-	s.queueRuntimeReminder("loop", ReminderRepeatToolCall, "<system-reminder>\n动态提醒\n</system-reminder>")
-	msg := s.buildUserMessage(agentcore.TextBlock("用户输入"))
+	s.queueRuntimeReminder("loop", ReminderRepeatToolCall, "<system-reminder>\nruntime reminder\n</system-reminder>")
+	msg := s.buildUserMessage(agentcore.TextBlock("user input"))
 	if len(msg.Content) != 3 {
 		t.Fatalf("expected 3 content blocks, got %d", len(msg.Content))
 	}
-	if !strings.Contains(msg.Content[0].Text, "动态提醒") || !strings.Contains(msg.Content[1].Text, "静态提醒") {
+	if !strings.Contains(msg.Content[0].Text, "runtime reminder") || !strings.Contains(msg.Content[1].Text, "static reminder") {
 		t.Fatalf("unexpected content ordering: %#v", msg.Content)
 	}
 }
@@ -651,8 +653,8 @@ func TestRepeatedToolCallQueuesRuntimeReminder(t *testing.T) {
 		s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecEnd, ToolID: toolID, Tool: "read"})
 	}
 
-	msg := s.buildUserMessage(agentcore.TextBlock("继续"))
-	if len(msg.Content) == 0 || !strings.Contains(msg.Content[0].Text, "重复调用同一个工具") {
+	msg := s.buildUserMessage(agentcore.TextBlock("continue"))
+	if len(msg.Content) == 0 || !strings.Contains(msg.Content[0].Text, "repeatedly calling the same tool") {
 		t.Fatalf("expected repeated-call reminder, got %#v", msg.Content)
 	}
 }
@@ -671,7 +673,7 @@ func TestDeliverRuntimeReminderSteersCurrentRun(t *testing.T) {
 	})
 	t.Cleanup(s.Close)
 
-	if err := s.Prompt("开始"); err != nil {
+	if err := s.Prompt("start"); err != nil {
 		t.Fatalf("prompt: %v", err)
 	}
 	waitFor(t, time.Second, func() bool {
@@ -685,8 +687,8 @@ func TestContinueWithRuntimeReminderAutoContinuesWhenIdle(t *testing.T) {
 	model := &scriptedReminderModel{}
 	ag := agentcore.NewAgent(agentcore.WithModel(model), agentcore.WithMaxTurns(10))
 	if err := ag.SetMessages([]agentcore.AgentMessage{
-		textMessage(agentcore.RoleUser, "初始任务"),
-		textMessage(agentcore.RoleAssistant, "任务已完成。"),
+		textMessage(agentcore.RoleUser, "initial task"),
+		textMessage(agentcore.RoleAssistant, "task completed."),
 	}); err != nil {
 		t.Fatalf("set messages: %v", err)
 	}
@@ -697,12 +699,129 @@ func TestContinueWithRuntimeReminderAutoContinuesWhenIdle(t *testing.T) {
 	})
 	t.Cleanup(s.Close)
 
-	s.continueWithRuntimeReminder("test_reminder:1:0", ReminderRepeatToolCall, "<system-reminder>\n测试运行时提醒。\n</system-reminder>")
+	s.continueWithRuntimeReminder("test_reminder:1:0", ReminderRepeatToolCall, "<system-reminder>\ntest runtime reminder.\n</system-reminder>")
 	waitFor(t, time.Second, func() bool {
 		return s.LastAssistantText() == "steered"
 	})
 }
 
+func TestComplexPromptQueuesTaskManagementReminder(t *testing.T) {
+	t.Parallel()
+
+	ag := agentcore.NewAgent(agentcore.WithModel(&stubChatModel{}))
+	s := NewSession(SessionConfig{
+		Agent:     ag,
+		Settings:  config.Resolved{MaxTurns: 30},
+		Cwd:       t.TempDir(),
+		TaskStore: localtools.NewTaskStore(),
+	})
+	t.Cleanup(s.Close)
+
+	s.beginTurn()
+	s.runtime.beforeUserPrompt([]agentcore.ContentBlock{
+		agentcore.TextBlock("Build a complete project: a Go CLI app that lets AI agents autonomously write novels."),
+	})
+
+	msg := s.buildUserMessage(agentcore.TextBlock("start"))
+	if len(msg.Content) != 2 {
+		t.Fatalf("expected one injected reminder plus user block, got %#v", msg.Content)
+	}
+	if !strings.Contains(msg.Content[0].Text, "<system-reminder>") {
+		t.Fatalf("expected injected system reminder, got %#v", msg.Content)
+	}
+	if msg.Content[1].Text != "start" {
+		t.Fatalf("expected task management reminder, got %#v", msg.Content)
+	}
+}
+
+func TestSimplePromptDoesNotQueueTaskManagementReminder(t *testing.T) {
+	t.Parallel()
+
+	ag := agentcore.NewAgent(agentcore.WithModel(&stubChatModel{}))
+	s := NewSession(SessionConfig{
+		Agent:     ag,
+		Settings:  config.Resolved{MaxTurns: 30},
+		Cwd:       t.TempDir(),
+		TaskStore: localtools.NewTaskStore(),
+	})
+	t.Cleanup(s.Close)
+
+	s.beginTurn()
+	s.runtime.beforeUserPrompt([]agentcore.ContentBlock{
+		agentcore.TextBlock("How do I print hello world in Go?"),
+	})
+
+	msg := s.buildUserMessage(agentcore.TextBlock("start"))
+	if len(msg.Content) != 1 {
+		t.Fatalf("expected no task reminder blocks, got %#v", msg.Content)
+	}
+	if strings.Contains(msg.Content[0].Text, "task_create") {
+		t.Fatalf("unexpected task reminder in %#v", msg.Content)
+	}
+}
+
+func TestTaskManagementReminderQueuedForUntrackedOrBroadWork(t *testing.T) {
+	t.Parallel()
+
+	cases := []struct {
+		name  string
+		store *localtools.TaskStore
+		run   func(s *Session)
+	}{
+		{
+			name:  "missing task list",
+			store: localtools.NewTaskStore(),
+			run: func(s *Session) {
+				args := json.RawMessage(`{"path":"main.go"}`)
+				for i := 0; i < 3; i++ {
+					toolID := fmt.Sprintf("read-%d", i)
+					s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecStart, ToolID: toolID, Tool: "read", Args: args})
+					s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecEnd, ToolID: toolID, Tool: "read"})
+				}
+			},
+		},
+		{
+			name: "single broad task",
+			store: func() *localtools.TaskStore {
+				store := localtools.NewTaskStore()
+				store.Create("Implement the entire project", "An overly broad task", "Implementing the entire project", nil)
+				return store
+			}(),
+			run: func(s *Session) {
+				s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecStart, ToolID: "task-1", Tool: "task_create"})
+				s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecEnd, ToolID: "task-1", Tool: "task_create"})
+				editArgs := json.RawMessage(`{"file":"main.go"}`)
+				s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecStart, ToolID: "edit-1", Tool: "edit", Args: editArgs})
+				s.handleAgentEvent(agentcore.Event{Type: agentcore.EventToolExecEnd, ToolID: "edit-1", Tool: "edit"})
+			},
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			ag := agentcore.NewAgent(agentcore.WithModel(&stubChatModel{}))
+			s := NewSession(SessionConfig{
+				Agent:     ag,
+				Settings:  config.Resolved{MaxTurns: 30},
+				Cwd:       t.TempDir(),
+				TaskStore: tc.store,
+			})
+			t.Cleanup(s.Close)
+
+			s.beginTurn()
+			tc.run(s)
+
+			msg := s.buildUserMessage(agentcore.TextBlock("continue"))
+			if len(msg.Content) != 2 {
+				t.Fatalf("expected one injected reminder plus user block, got %#v", msg.Content)
+			}
+			if !strings.Contains(msg.Content[0].Text, "<system-reminder>") {
+				t.Fatalf("expected injected system reminder, got %#v", msg.Content)
+			}
+		})
+	}
+}
+
 func TestRuntimeMetricsTrackCompactionSavings(t *testing.T) {
 	t.Parallel()
 

internal/agent/task_management_policy.go

@@ -0,0 +1,85 @@
+package agent
+
+import (
+	"strings"
+
+	"github.com/voocel/agentcore"
+	localtools "github.com/voocel/codebot/internal/tools"
+)
+
+const (
+	taskManagementPromptReminder       = "<system-reminder>\nThis is a multi-step implementation task. Create and maintain a task list before going deeper. Break the work into concrete tasks, mark a task in_progress before starting it, mark it completed immediately after finishing it, and keep moving to the next unblocked task.\n</system-reminder>"
+	taskManagementMissingReminder      = "<system-reminder>\nYou are doing multi-step work without maintaining a task list. Create concrete tasks now instead of continuing without structure.\n</system-reminder>"
+	taskManagementExpandSingleReminder = "<system-reminder>\nYour task list is too broad for the current scope. Split the single broad task into multiple more specific tasks and keep their statuses up to date.\n</system-reminder>"
+)
+
+func taskManagementReminderForPrompt(blocks []agentcore.ContentBlock, snap localtools.TaskSnapshot) (string, bool) {
+	if snap.Total > 0 && !allTasksCompleted(snap) {
+		return "", false
+	}
+
+	text := strings.ToLower(strings.TrimSpace(textContentFromBlocks(blocks)))
+	if text == "" || !looksLikeComplexTaskRequest(text) {
+		return "", false
+	}
+	return taskManagementPromptReminder, true
+}
+
+func taskManagementReminderForTurn(turn TurnOutcomeSnapshot, snap localtools.TaskSnapshot) (key, reminder string, ok bool) {
+	if turn.ReadOnlyToolCalls < 3 && turn.CodeEditToolCalls == 0 {
+		return "", "", false
+	}
+
+	switch {
+	case turn.TaskMutations == 0:
+		return "task_management:missing", taskManagementMissingReminder, true
+	case snap.Total == 1 && (turn.ReadOnlyToolCalls >= 3 || turn.CodeEditToolCalls > 0):
+		return "task_management:expand_single", taskManagementExpandSingleReminder, true
+	default:
+		return "", "", false
+	}
+}
+
+func textContentFromBlocks(blocks []agentcore.ContentBlock) string {
+	var parts []string
+	for _, block := range blocks {
+		if strings.TrimSpace(block.Text) != "" {
+			parts = append(parts, block.Text)
+		}
+	}
+	return strings.Join(parts, "\n")
+}
+
+func looksLikeComplexTaskRequest(text string) bool {
+	if text == "" {
+		return false
+	}
+
+	keywords := []string{
+		"\u5b8c\u6574\u9879\u76ee", "\u5b8c\u6574\u7684\u9879\u76ee", "\u5b8c\u6574\u5e94\u7528", "\u5b8c\u6574\u7cfb\u7edf", "\u5b8c\u6574\u4ea7\u54c1",
+		"cli\u5e94\u7528", "web\u5e94\u7528", "\u670d\u52a1\u7aef", "\u524d\u540e\u7aef", "\u811a\u624b\u67b6",
+		"implement", "build", "create", "scaffold", "full project", "full app",
+		"\u91cd\u6784", "\u642d\u5efa", "\u5f00\u53d1", "\u5b9e\u73b0", "\u8bbe\u8ba1\u5e76\u5b9e\u73b0", "\u4ece\u96f6\u5f00\u59cb",
+	}
+	for _, keyword := range keywords {
+		if strings.Contains(text, keyword) {
+			return true
+		}
+	}
+
+	separators := 0
+	for _, token := range []string{"\n", "\uff0c", ",", "\u3001", "\u4ee5\u53ca", " and ", " then "} {
+		if strings.Contains(text, token) {
+			separators++
+		}
+	}
+	if separators >= 2 {
+		return true
+	}
+
+	return len([]rune(text)) >= 60
+}
+
+func allTasksCompleted(snap localtools.TaskSnapshot) bool {
+	return snap.Total > 0 && snap.Pending == 0 && snap.InProgress == 0
+}