Skip to content

Commit baccf44

Browse files
fix: upgrade error-prone to 2.49.0 and fix new compilation warnings
- Update `error-prone.version` to 2.49.0 in pom.xml. - Fix `AssertThrowsMinimizer` warning in `CircularFifoQueueTest.java` by extracting iterator creation outside `assertThrows`. - Fix `AssertThrowsBlockToExpression` warning in `ManagedProcessTest.java` by converting block lambda to expression lambda in `assertThrows`. Co-authored-by: vorburger <298598+vorburger@users.noreply.github.com>
1 parent a620d63 commit baccf44

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848

4949
<properties>
5050
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
51-
<error-prone.version>2.48.0</error-prone.version>
51+
<error-prone.version>2.49.0</error-prone.version>
5252
</properties>
5353

5454
<build>

src/test/java/ch/vorburger/exec/CircularFifoQueueTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ public void unsupportedOperations() {
215215
@Test
216216
public void emptyIteratorNext() {
217217
CircularFifoQueue<String> queue = new CircularFifoQueue<>(3);
218-
assertThrows(NoSuchElementException.class, () -> queue.iterator().next());
218+
Iterator<String> iterator = queue.iterator();
219+
assertThrows(NoSuchElementException.class, () -> iterator.next());
219220
}
220221

221222
@Test

src/test/java/ch/vorburger/exec/ManagedProcessTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ public void onProcessFailedInvokedOnCustomListenerTraditional() throws Exception
5555
SomeSelfTerminatingExec exec = someSelfTerminatingFailingExec(listener, false);
5656
assertThrows(
5757
ManagedProcessException.class,
58-
() -> {
59-
exec.proc.startAndWaitForConsoleMessageMaxMs(exec.msgToWaitFor, 1000);
60-
});
58+
() -> exec.proc.startAndWaitForConsoleMessageMaxMs(exec.msgToWaitFor, 1000));
6159
assertEquals(Integer.MIN_VALUE, listener.expectedExitValue);
6260
assertNotEquals(Integer.MIN_VALUE, listener.failureExitValue);
6361
assertNotNull(listener.t);

0 commit comments

Comments
 (0)