Skip to content

fix: upgrade error-prone to 2.49.0 and fix new compilation warnings#349

Merged
vorburger merged 1 commit into
mainfrom
update-error-prone-2.49.0-7102778353104035930
Apr 7, 2026
Merged

fix: upgrade error-prone to 2.49.0 and fix new compilation warnings#349
vorburger merged 1 commit into
mainfrom
update-error-prone-2.49.0-7102778353104035930

Conversation

@vorburger
Copy link
Copy Markdown
Owner

This PR upgrades error-prone to version 2.49.0 and resolves the new compilation warnings introduced by the update. Specifically:

  • Fixed AssertThrowsMinimizer warning in CircularFifoQueueTest.java by extracting iterator creation outside of the assertThrows block.
  • Fixed AssertThrowsBlockToExpression warning in ManagedProcessTest.java by replacing the block lambda with an expression lambda within assertThrows.

PR created automatically by Jules for task 7102778353104035930 started by @vorburger

- Update `error-prone.version` to 2.49.0 in pom.xml.
- Fix `AssertThrowsMinimizer` warning in `CircularFifoQueueTest.java` by extracting iterator creation outside `assertThrows`.
- Fix `AssertThrowsBlockToExpression` warning in `ManagedProcessTest.java` by converting block lambda to expression lambda in `assertThrows`.

Co-authored-by: vorburger <298598+vorburger@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings April 7, 2026 21:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades Error Prone to 2.49.0 and adjusts a couple of JUnit assertThrows usages in tests to satisfy new Error Prone warnings introduced by the upgrade.

Changes:

  • Bump error-prone.version from 2.48.0 to 2.49.0 in pom.xml.
  • Refactor assertThrows in ManagedProcessTest to use an expression lambda (avoids AssertThrowsBlockToExpression).
  • Refactor assertThrows in CircularFifoQueueTest to create the iterator outside the lambda (avoids AssertThrowsMinimizer).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pom.xml Updates Error Prone version property to 2.49.0 (used for core + annotations).
src/test/java/ch/vorburger/exec/ManagedProcessTest.java Simplifies assertThrows lambda to avoid new compilation warning.
src/test/java/ch/vorburger/exec/CircularFifoQueueTest.java Moves iterator creation out of assertThrows lambda to avoid minimizer warning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the error-prone dependency version to 2.49.0 and performs minor refactoring in the test suite to improve code readability and style. I have no feedback to provide.

@vorburger vorburger merged commit baccf44 into main Apr 7, 2026
8 checks passed
@vorburger vorburger deleted the update-error-prone-2.49.0-7102778353104035930 branch April 7, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants