fix: upgrade error-prone to 2.49.0 and fix new compilation warnings#349
Conversation
- Update `error-prone.version` to 2.49.0 in pom.xml. - Fix `AssertThrowsMinimizer` warning in `CircularFifoQueueTest.java` by extracting iterator creation outside `assertThrows`. - Fix `AssertThrowsBlockToExpression` warning in `ManagedProcessTest.java` by converting block lambda to expression lambda in `assertThrows`. Co-authored-by: vorburger <298598+vorburger@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Upgrades Error Prone to 2.49.0 and adjusts a couple of JUnit assertThrows usages in tests to satisfy new Error Prone warnings introduced by the upgrade.
Changes:
- Bump
error-prone.versionfrom 2.48.0 to 2.49.0 inpom.xml. - Refactor
assertThrowsinManagedProcessTestto use an expression lambda (avoidsAssertThrowsBlockToExpression). - Refactor
assertThrowsinCircularFifoQueueTestto create the iterator outside the lambda (avoidsAssertThrowsMinimizer).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pom.xml |
Updates Error Prone version property to 2.49.0 (used for core + annotations). |
src/test/java/ch/vorburger/exec/ManagedProcessTest.java |
Simplifies assertThrows lambda to avoid new compilation warning. |
src/test/java/ch/vorburger/exec/CircularFifoQueueTest.java |
Moves iterator creation out of assertThrows lambda to avoid minimizer warning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR upgrades error-prone to version 2.49.0 and resolves the new compilation warnings introduced by the update. Specifically:
AssertThrowsMinimizerwarning inCircularFifoQueueTest.javaby extracting iterator creation outside of theassertThrowsblock.AssertThrowsBlockToExpressionwarning inManagedProcessTest.javaby replacing the block lambda with an expression lambda withinassertThrows.PR created automatically by Jules for task 7102778353104035930 started by @vorburger