Commit 49c73b0
[RFC 60] Address fourth /rfc-review round: Stage 2 norm_factor + D.15 polish
Two MINOR fixes catching internal inconsistencies introduced by iteration
3's additions.
MINORs:
- D.6 Stage 2 encode pseudocode was missing the `norm_factor` parameter
added to D.4/D.5 in iteration 3. Stage 2 normalizes per block
dimension B (`B^(-num_rounds/2)`), not per padded_dim. Fixed and added
a comment clarifying that Stage 2 inherits Stage 1 / Stage 1.5's
scale-`S` decision (S = 1 today; EDEN-S keyed on B once Stage 1.5
lands).
- D.15 `extract_signs` was named in the SORF pseudocode but its body
was an unlabeled for-loop above. Wrapped the body in an explicit
function signature so the reader doesn't have to infer the binding.
Signed-off-by: Will Manning <will@willmanning.io>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>1 parent 50b6308 commit 49c73b0
1 file changed
Lines changed: 14 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2084 | 2084 | | |
2085 | 2085 | | |
2086 | 2086 | | |
| 2087 | + | |
2087 | 2088 | | |
2088 | 2089 | | |
2089 | 2090 | | |
2090 | 2091 | | |
2091 | 2092 | | |
2092 | 2093 | | |
2093 | | - | |
| 2094 | + | |
| 2095 | + | |
| 2096 | + | |
2094 | 2097 | | |
| 2098 | + | |
| 2099 | + | |
2095 | 2100 | | |
2096 | 2101 | | |
2097 | 2102 | | |
| |||
2346 | 2351 | | |
2347 | 2352 | | |
2348 | 2353 | | |
2349 | | - | |
2350 | | - | |
2351 | | - | |
2352 | | - | |
2353 | | - | |
| 2354 | + | |
| 2355 | + | |
| 2356 | + | |
| 2357 | + | |
| 2358 | + | |
| 2359 | + | |
| 2360 | + | |
| 2361 | + | |
2354 | 2362 | | |
2355 | 2363 | | |
2356 | 2364 | | |
| |||
0 commit comments