Commit 001f44b
authored
Don't re-run benchmarks nightly (#7338)
We currently run some of the same benchmarks both nightly and
per-commit, which pollutes the data file, which causes
[failures](https://github.com/vortex-data/vortex/actions/runs/24129409553/job/70402005592)
when comparing runs like in and is also just wasteful.
```
File "/home/runner/_work/vortex/vortex/scripts/compare-benchmark-jsons.py", line 629, in <module>
main()
File "/home/runner/_work/vortex/vortex/scripts/compare-benchmark-jsons.py", line 516, in main
statistical_analysis = build_statistical_analysis(df3, threshold_pct)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/_work/vortex/vortex/scripts/compare-benchmark-jsons.py", line 300, in build_statistical_analysis
log_ratio_table = detail_df.pivot(index="query", columns="combo", values="log_ratio")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/uv/environments-v2/compare-benchmark-jsons-6c3240f590b6fe2d/lib/python3.11/site-packages/pandas/core/frame.py", line 10974, in pivot
return pivot(self, index=index, columns=columns, values=values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/uv/environments-v2/compare-benchmark-jsons-6c3240f590b6fe2d/lib/python3.11/site-packages/pandas/core/reshape/pivot.py", line 910, in pivot
result = cast("DataFrame", indexed.unstack(columns_listlike)) # type: ignore[arg-type]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/uv/environments-v2/compare-benchmark-jsons-6c3240f590b6fe2d/lib/python3.11/site-packages/pandas/core/series.py", line 4501, in unstack
return unstack(self, level, fill_value, sort)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/uv/environments-v2/compare-benchmark-jsons-6c3240f590b6fe2d/lib/python3.11/site-packages/pandas/core/reshape/reshape.py", line 596, in unstack
unstacker = _Unstacker(
^^^^^^^^^^^
File "/home/runner/.cache/uv/environments-v2/compare-benchmark-jsons-6c3240f590b6fe2d/lib/python3.11/site-packages/pandas/core/reshape/reshape.py", line 176, in __init__
self._make_selectors()
File "/home/runner/.cache/uv/environments-v2/compare-benchmark-jsons-6c3240f590b6fe2d/lib/python3.11/site-packages/pandas/core/reshape/reshape.py", line 232, in _make_selectors
raise ValueError("Index contains duplicate entries, cannot reshape")
ValueError: Index contains duplicate entries, cannot reshape
```
Signed-off-by: Adam Gutglick <adam@spiraldb.com>1 parent 95befa7 commit 001f44b
1 file changed
+0
-28
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 28 | | |
54 | 29 | | |
55 | 30 | | |
| |||
74 | 49 | | |
75 | 50 | | |
76 | 51 | | |
77 | | - | |
78 | | - | |
79 | | - | |
0 commit comments