wip

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

encodings/datetime-parts/src/compute/rules.rs

@@ -54,7 +54,9 @@ impl ArrayParentReduceRule<DateTimeParts> for DTPFilterPushDownRule {
     ) -> VortexResult<Option<ArrayRef>> {
         debug_assert_eq!(child_idx, 0);
 
-        if !child.seconds().is::<Constant>() || !child.subseconds().is::<Constant>() {
+        if *child.seconds().encoding_id() != Constant::ID
+            || *child.subseconds().encoding_id() != Constant::ID
+        {
             return Ok(None);
         }
 

vortex-array/src/aggregate_fn/fns/is_constant/mod.rs

@@ -107,7 +107,8 @@ pub fn is_constant(array: &ArrayRef, ctx: &mut ExecutionCtx) -> VortexResult<boo
     }
 
     // Constant and null arrays are always constant.
-    if array.is::<Constant>() || array.is::<Null>() {
+    let id = array.encoding_id();
+    if *id == Constant::ID || *id == Null::ID {
         array
             .statistics()
             .set(Stat::IsConstant, Precision::Exact(true.into()));

vortex-array/src/aggregate_fn/fns/is_sorted/mod.rs

@@ -88,7 +88,8 @@ fn is_sorted_impl(array: &ArrayRef, strict: bool, ctx: &mut ExecutionCtx) -> Vor
     }
 
     // Constant and null arrays are always sorted, but not strict sorted.
-    if array.is::<Constant>() || array.is::<Null>() {
+    let id = array.encoding_id();
+    if *id == Constant::ID || *id == Null::ID {
         let result = !strict;
         cache_is_sorted(array, strict, result);
         return Ok(result);