Remove redundant PiecewiseSequential u64 index helper

Signed-off-by: Daniel King <dan@spiraldb.com>

Author: danking

vortex-array/src/arrays/piecewise_sequential/mod.rs

@@ -8,7 +8,6 @@
 //! can gather contiguous runs without materializing one index per element.
 
 use itertools::Itertools;
-use num_traits::AsPrimitive;
 use vortex_buffer::BufferMut;
 use vortex_error::VortexResult;
 use vortex_error::vortex_bail;
@@ -72,15 +71,10 @@ pub(crate) fn index_value_to_usize<T: UnsignedPType>(value: T) -> usize {
 }
 
 #[inline]
-pub(crate) fn index_value_to_u64<T: UnsignedPType + AsPrimitive<u64>>(value: T) -> u64 {
-    value.as_()
-}
-
-#[inline]
-pub(crate) fn checked_range_end(start: u64, length: usize) -> VortexResult<u64> {
+pub(crate) fn checked_range_end(start: usize, length: usize) -> VortexResult<usize> {
     start
-        .checked_add(length as u64)
-        .ok_or_else(|| vortex_error::vortex_err!("PiecewiseSequentialArray range overflows u64"))
+        .checked_add(length)
+        .ok_or_else(|| vortex_error::vortex_err!("PiecewiseSequentialArray range overflows usize"))
 }
 
 pub(crate) fn materialize_ranges<S, L>(
@@ -89,7 +83,7 @@ pub(crate) fn materialize_ranges<S, L>(
     output_len: usize,
 ) -> VortexResult<BufferMut<u64>>
 where
-    S: UnsignedPType + AsPrimitive<u64>,
+    S: UnsignedPType,
     L: UnsignedPType,
 {
     let starts = starts.as_slice::<S>();
@@ -98,14 +92,14 @@ where
     let mut computed_len = 0usize;
 
     for (&start, &length) in starts.iter().zip_eq(lengths) {
-        let start = index_value_to_u64(start);
+        let start: usize = start.as_();
         let length = index_value_to_usize(length);
-        checked_range_end(start, length)?;
+        let end = checked_range_end(start, length)?;
         computed_len = computed_len.checked_add(length).ok_or_else(|| {
             vortex_error::vortex_err!("PiecewiseSequentialArray output length overflows usize")
         })?;
 
-        values.extend((0..length).map(|offset| start + offset as u64));
+        values.extend((start..end).map(|value| value as u64));
     }
 
     if computed_len != output_len {

vortex-array/src/arrays/piecewise_sequential/vtable.rs

@@ -30,7 +30,6 @@ use crate::arrays::piecewise_sequential::array::PiecewiseSequentialArraySlotsExt
 use crate::arrays::piecewise_sequential::array::PiecewiseSequentialSlots;
 use crate::arrays::piecewise_sequential::check_index_arrays;
 use crate::arrays::piecewise_sequential::execute_index_arrays;
-use crate::arrays::piecewise_sequential::index_value_to_u64;
 use crate::arrays::piecewise_sequential::index_value_to_usize;
 use crate::arrays::piecewise_sequential::materialize_ranges;
 use crate::arrays::primitive::PrimitiveArrayExt;
@@ -233,7 +232,7 @@ fn scalar_at<S, L>(
     index: usize,
 ) -> VortexResult<u64>
 where
-    S: crate::dtype::UnsignedPType + num_traits::AsPrimitive<u64>,
+    S: crate::dtype::UnsignedPType,
     L: crate::dtype::UnsignedPType,
 {
     let mut remaining = index;
@@ -244,7 +243,8 @@ where
     {
         let length = index_value_to_usize(length);
         if remaining < length {
-            return Ok(index_value_to_u64(start) + remaining as u64);
+            let start: usize = start.as_();
+            return Ok((start + remaining) as u64);
         }
         remaining -= length;
     }