Simplify

Signed-off-by: Dimitar Dimitrov <dimitar@spiraldb.com>

Author: dimitarvdimitrov

vortex-array/src/display/mod.rs

@@ -477,34 +477,27 @@ impl dyn DynArray + '_ {
             DisplayOptions::CommaSeparatedScalars {
                 omit_comma_after_space,
             } => {
-                write!(f, "{}", if f.alternate() { "[\n" } else { "[" })?;
+                let opening_brace= if f.alternate() { "[\n" } else { "[" };
+                let closing_brace = if f.alternate() { "\n]" } else { "]" };
+
                 let sep = if *omit_comma_after_space { "," } else { ", " };
                 let sep = if f.alternate() { ",\n" } else { sep };
                 let limit = self.len().min(f.precision().unwrap_or(DISPLAY_LIMIT));
                 let is_truncated = self.len() > limit;
+
+                let fmt_scalar = |i| self
+                    .scalar_at(i)
+                    .map_or_else(|e| format!("<error: {e}>"), |s| s.to_string());
+
                 write!(
                     f,
-                    "{}",
-                    (0..(limit - if is_truncated { 3 } else { 0 }))
-                        .map(|i| self
-                            .scalar_at(i)
-                            .map_or_else(|e| format!("<error: {e}>"), |s| s.to_string()))
+                    "{opening_brace}{}{closing_brace}",
+                    (0..limit.saturating_sub(3))
+                        .map(fmt_scalar)
+                        .chain(std::iter::repeat("...".to_string()).take(is_truncated as usize))
+                        .chain((self.len().saturating_sub(3)..self.len()).map(fmt_scalar))
                         .format(sep)
-                )?;
-                if is_truncated {
-                    write!(f, "{sep}...{sep}")?;
-                    write!(
-                        f,
-                        "{}",
-                        (self.len() - 3..self.len())
-                            .map(|i| self
-                                .scalar_at(i)
-                                .map_or_else(|e| format!("<error: {e}>"), |s| s.to_string()))
-                            .format(sep)
-                    )?;
-                }
-                let closing_brace = if f.alternate() { "\n]" } else { "]" };
-                write!(f, "{closing_brace}")
+                )
             }
             DisplayOptions::TreeDisplay {
                 buffers,