Skip to content

Commit 10b8173

Browse files
authored
Skip building binaries in when there are no tests (#8820)
## Rationale for this change We have many binaries in the main workspace, many of them don't contain any tests (in the final `main.rs` or equivalent file). ## What changes are included in this PR? Sets `test = false` for most binaries in the workspace, which means that running `cargo test` or `cargo nextest` won't build the final binary. I've also restructured `random-access` a bit (with claude's help) so it actually has a dedicated `lib.rs`. ## What APIs are changed? Are there any user-facing changes? None Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1 parent 94c4e96 commit 10b8173

13 files changed

Lines changed: 565 additions & 491 deletions

File tree

benchmarks/compress-bench/Cargo.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,12 @@ vortex-bench = { workspace = true }
3737
lance = ["dep:lance-bench"]
3838
unstable_encodings = ["vortex/unstable_encodings"]
3939

40+
[[bin]]
41+
name = "compress-bench"
42+
test = false
43+
44+
[lib]
45+
test = false
46+
4047
[lints]
4148
workspace = true

benchmarks/datafusion-bench/Cargo.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ publish = false
1717
[package.metadata.cargo-shear]
1818
ignored = ["vortex-cuda"]
1919

20+
[[bin]]
21+
name = "datafusion-bench"
22+
test = false
23+
24+
[lib]
25+
test = false
26+
2027
[dependencies]
2128
anyhow = { workspace = true }
2229
clap = { workspace = true, features = ["derive"] }

benchmarks/duckdb-bench/Cargo.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ publish = false
1717
[package.metadata.cargo-shear]
1818
ignored = ["vortex-cuda"]
1919

20+
[[bin]]
21+
name = "duckdb-bench"
22+
test = false
23+
24+
[lib]
25+
test = false
26+
2027
[dependencies]
2128
anyhow = { workspace = true }
2229
clap = { workspace = true, features = ["derive"] }

benchmarks/lance-bench/Cargo.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,12 @@ vortex-bench = { workspace = true }
3232
[features]
3333
unstable_encodings = ["vortex-bench/unstable_encodings"]
3434

35+
[lib]
36+
test = false
37+
38+
[[bin]]
39+
name = "lance-bench"
40+
test = false
41+
3542
[lints]
3643
workspace = true

benchmarks/random-access-bench/Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,9 @@ vortex-bench = { workspace = true }
2929
lance = ["dep:lance-bench"]
3030
unstable_encodings = ["vortex-bench/unstable_encodings"]
3131

32+
[[bin]]
33+
name = "random-access-bench"
34+
test = false
35+
3236
[lints]
3337
workspace = true

0 commit comments

Comments
 (0)