Skip to content

Commit 13417e9

Browse files
skip[ci]: use runs-on for generated-files job (#7021)
<!-- Thank you for submitting a pull request! We appreciate your time and effort. Please make sure to provide enough information so that we can review your pull request. The Summary and Testing sections below contain guidance on what to include. --> ## Summary <!-- If this PR is related to a tracked effort, please link to the relevant issue here (e.g., `Closes: #123`). Otherwise, feel free to ignore / delete this. In this section, please: 1. Explain the rationale for this change. 2. Summarize the changes included in this PR. A general rule of thumb is that larger PRs should have larger summaries. If there are a lot of changes, please help us review the code by explaining what was changed and why. If there is an issue or discussion attached, there is no need to duplicate all the details, but clarity is always preferred over brevity. --> Closes: #000 <!-- ## API Changes Uncomment this section if there are any user-facing changes. Consider whether the change affects users in one of the following ways: 1. Breaks public APIs in some way. 2. Changes the underlying behavior of one of the engine integrations. 3. Should some documentation be updated to reflect this change? If a public API is changed in a breaking manner, make sure to add the appropriate label. You can run `./scripts/public-api.sh` locally to see if there are any public API changes (and this also runs in our CI). --> ## Testing <!-- Please describe how this change was tested. Here are some common categories for testing in Vortex: 1. Verifying existing behavior is maintained. 2. Verifying new behavior and functionality works correctly. 3. Serialization compatibility (backwards and forwards) should be maintained or explicitly broken. --> --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
1 parent 61bc044 commit 13417e9

2 files changed

Lines changed: 43 additions & 36 deletions

File tree

.github/actions/setup-rust/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ runs:
8585
uses: ./.github/actions/setup-protoc
8686

8787
- name: Install Ninja (for DuckDB build system)
88-
uses: seanmiddleditch/gha-setup-ninja@master
88+
uses: seanmiddleditch/gha-setup-ninja@v6
8989

9090
- name: Install Sweep
9191
shell: bash

.github/workflows/ci.yml

Lines changed: 42 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ env:
2828
jobs:
2929
lint-toml:
3030
runs-on: ubuntu-latest
31-
timeout-minutes: 120
31+
timeout-minutes: 40
3232
steps:
3333
- uses: actions/checkout@v6
3434
- uses: spiraldb/actions/.github/actions/lint-toml@0.18.5
3535

3636
validate-workflow-yaml:
3737
runs-on: ubuntu-latest
38-
timeout-minutes: 120
38+
timeout-minutes: 40
3939
steps:
4040
- uses: actions/checkout@v6
4141
- name: Validate YAML file
@@ -52,7 +52,7 @@ jobs:
5252
${{ github.repository == 'vortex-data/vortex'
5353
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=python-lint', github.run_id)
5454
|| 'ubuntu-latest' }}
55-
timeout-minutes: 120
55+
timeout-minutes: 40
5656
steps:
5757
- uses: runs-on/action@v2
5858
if: github.repository == 'vortex-data/vortex'
@@ -77,7 +77,7 @@ jobs:
7777
${{ github.repository == 'vortex-data/vortex'
7878
&& format('runs-on={0}/runner=amd64-large/image=ubuntu24-full-x64-pre-v2/tag=python-test', github.run_id)
7979
|| 'ubuntu-latest' }}
80-
timeout-minutes: 120
80+
timeout-minutes: 40
8181
env:
8282
RUST_LOG: "info,uv=debug"
8383
MATURIN_PEP517_ARGS: "--profile dev"
@@ -115,7 +115,7 @@ jobs:
115115
python-wheel-build:
116116
name: "Python (wheel build)"
117117
runs-on: ubuntu-latest
118-
timeout-minutes: 120
118+
timeout-minutes: 40
119119
steps:
120120
- uses: actions/checkout@v6
121121
- name: Rust Dependency Cache
@@ -126,7 +126,7 @@ jobs:
126126
with:
127127
repo-token: ${{ secrets.GITHUB_TOKEN }}
128128
enable-sccache: "false"
129-
- uses: mlugg/setup-zig@v2
129+
- uses: mlugg/setup-zig@v2.2.1
130130
- name: Install uv
131131
uses: spiraldb/actions/.github/actions/setup-uv@0.18.5
132132
with:
@@ -155,7 +155,7 @@ jobs:
155155

156156
rust-docs:
157157
name: "Rust (docs)"
158-
timeout-minutes: 120
158+
timeout-minutes: 40
159159
runs-on: >-
160160
${{ github.repository == 'vortex-data/vortex'
161161
&& format('runs-on={0}/runner=amd64-small/image=ubuntu24-full-x64-pre-v2/tag=rust-docs', github.run_id)
@@ -175,7 +175,7 @@ jobs:
175175
176176
build-rust:
177177
name: "Rust build (${{matrix.config.name}})"
178-
timeout-minutes: 120
178+
timeout-minutes: 40
179179
runs-on: >-
180180
${{ github.repository == 'vortex-data/vortex'
181181
&& format('runs-on={0}/runner={1}/image=ubuntu24-full-x64-pre-v2/tag={2}', github.run_id, matrix.config.runner, matrix.config.name)
@@ -188,10 +188,10 @@ jobs:
188188
matrix:
189189
config:
190190
- name: "all-features"
191-
runner: amd64-medium
191+
runner: amd64-large
192192
args: "--all-features --all-targets"
193193
- name: "default features"
194-
runner: amd64-medium
194+
runner: amd64-large
195195
args: "--all-targets"
196196
- name: "with tokio dispatcher"
197197
runner: amd64-small
@@ -223,7 +223,7 @@ jobs:
223223
224224
check-min-deps:
225225
name: "Check build with minimal dependencies"
226-
timeout-minutes: 120
226+
timeout-minutes: 40
227227
runs-on: >-
228228
${{ github.repository == 'vortex-data/vortex'
229229
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=rust-min-deps', github.run_id)
@@ -239,7 +239,7 @@ jobs:
239239

240240
rust-lint:
241241
name: "Rust (lint)"
242-
timeout-minutes: 120
242+
timeout-minutes: 40
243243
runs-on: >-
244244
${{ github.repository == 'vortex-data/vortex'
245245
&& format('runs-on={0}/runner=amd64-large/image=ubuntu24-full-x64-pre-v2/tag=rust-lint', github.run_id)
@@ -279,7 +279,7 @@ jobs:
279279
280280
rust-lint-no-default:
281281
name: "Rust (lint, no default)"
282-
timeout-minutes: 120
282+
timeout-minutes: 40
283283
runs-on: >-
284284
${{ github.repository == 'vortex-data/vortex'
285285
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=rust-lint-no-default', github.run_id)
@@ -298,7 +298,7 @@ jobs:
298298
299299
public-api:
300300
name: "Public API lock files"
301-
timeout-minutes: 120
301+
timeout-minutes: 40
302302
runs-on: >-
303303
${{ github.repository == 'vortex-data/vortex'
304304
&& format('runs-on={0}/runner=amd64-xsmall/image=ubuntu24-full-x64-pre-v2/tag=public-api', github.run_id)
@@ -332,7 +332,7 @@ jobs:
332332
333333
rust-coverage:
334334
name: "Rust tests (coverage) (${{ matrix.suite }})"
335-
timeout-minutes: 120
335+
timeout-minutes: 40
336336
permissions:
337337
id-token: write
338338
strategy:
@@ -381,7 +381,7 @@ jobs:
381381

382382
rust-test:
383383
name: "Rust tests (sanitizer)"
384-
timeout-minutes: 120
384+
timeout-minutes: 40
385385
runs-on: >-
386386
${{ github.repository == 'vortex-data/vortex'
387387
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=rust-test-sanitizer', github.run_id)
@@ -428,7 +428,7 @@ jobs:
428428
cuda-build-lint:
429429
if: github.repository == 'vortex-data/vortex'
430430
name: "CUDA build & lint"
431-
timeout-minutes: 120
431+
timeout-minutes: 40
432432
runs-on: runs-on=${{ github.run_id }}/runner=gpu/tag=cuda-build
433433
steps:
434434
- uses: runs-on/action@v2
@@ -556,7 +556,7 @@ jobs:
556556
557557
rust-test-other:
558558
name: "Rust tests (${{ matrix.os }})"
559-
timeout-minutes: 120
559+
timeout-minutes: 40
560560
strategy:
561561
fail-fast: false
562562
matrix:
@@ -616,7 +616,7 @@ jobs:
616616
${{ github.repository == 'vortex-data/vortex'
617617
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=java', github.run_id)
618618
|| 'ubuntu-latest' }}
619-
timeout-minutes: 120
619+
timeout-minutes: 40
620620
steps:
621621
- uses: runs-on/action@v2
622622
if: github.repository == 'vortex-data/vortex'
@@ -640,7 +640,7 @@ jobs:
640640
- { shard: 7, name: "Encodings 4", packages: "vortex-sparse vortex-zigzag vortex-zstd" }
641641
- { shard: 8, name: "Storage formats", packages: "vortex-flatbuffers vortex-proto vortex-btrblocks" }
642642
name: "Benchmark with Codspeed (Shard #${{ matrix.shard }})"
643-
timeout-minutes: 120
643+
timeout-minutes: 40
644644
runs-on: >-
645645
${{ github.repository == 'vortex-data/vortex'
646646
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=bench-codspeed-{1}', github.run_id, matrix.shard)
@@ -656,7 +656,7 @@ jobs:
656656
- uses: ./.github/actions/setup-prebuild
657657
- uses: ./.github/actions/system-info
658658
- name: Install Codspeed
659-
uses: taiki-e/cache-cargo-install-action@24c4eaa867646941dd8cd6f08c1497ea68d732ba
659+
uses: taiki-e/cache-cargo-install-action@59027ebf20a9617c4e819eb53ccd2673cb162b89
660660
with:
661661
tool: cargo-codspeed
662662
- name: Build benchmarks
@@ -673,7 +673,7 @@ jobs:
673673
license-check-and-audit-check:
674674
name: License Check and Audit Check
675675
runs-on: ubuntu-latest
676-
timeout-minutes: 120
676+
timeout-minutes: 40
677677
strategy:
678678
matrix:
679679
checks:
@@ -689,7 +689,7 @@ jobs:
689689

690690
cxx-test:
691691
name: "C++ build"
692-
timeout-minutes: 120
692+
timeout-minutes: 40
693693
runs-on: >-
694694
${{ github.repository == 'vortex-data/vortex'
695695
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=cxx-build', github.run_id)
@@ -740,15 +740,18 @@ jobs:
740740
wasm-integration:
741741
name: "wasm-integration"
742742
runs-on: ubuntu-latest
743-
timeout-minutes: 120
743+
timeout-minutes: 40
744744
steps:
745745
- uses: actions/checkout@v6
746746
- uses: ./.github/actions/setup-rust
747747
with:
748748
repo-token: ${{ secrets.GITHUB_TOKEN }}
749749
targets: "wasm32-wasip1"
750750
- name: Setup Wasmer
751-
uses: wasmerio/setup-wasmer@v3.1
751+
shell: bash
752+
run: |
753+
curl https://get.wasmer.io -sSfL | sh
754+
echo "$HOME/.wasmer/bin" >> $GITHUB_PATH
752755
- run: cargo build --target wasm32-wasip1
753756
working-directory: ./wasm-test
754757
- run: wasmer run ./target/wasm32-wasip1/debug/wasm-test.wasm
@@ -760,7 +763,7 @@ jobs:
760763
${{ github.repository == 'vortex-data/vortex'
761764
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=rust-miri', github.run_id)
762765
|| 'ubuntu-latest' }}
763-
timeout-minutes: 120
766+
timeout-minutes: 40
764767
env:
765768
MIRIFLAGS: -Zmiri-strict-provenance -Zmiri-symbolic-alignment-check -Zmiri-disable-isolation -Zmiri-env-forward=RUST_BACKTRACE
766769
RUSTFLAGS: "-A warnings --cfg vortex_nightly"
@@ -779,16 +782,20 @@ jobs:
779782

780783
generated-files:
781784
name: "Check generated source files are up to date"
782-
runs-on: ubuntu-latest
783-
timeout-minutes: 120
785+
runs-on: >-
786+
${{ github.repository == 'vortex-data/vortex'
787+
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=generated-files', github.run_id)
788+
|| 'ubuntu-latest' }}
789+
timeout-minutes: 40
784790
steps:
785-
- uses: actions/checkout@v6
786-
- uses: ./.github/actions/setup-rust
791+
- uses: runs-on/action@v2
792+
if: github.repository == 'vortex-data/vortex'
787793
with:
788-
repo-token: ${{ secrets.GITHUB_TOKEN }}
794+
sccache: s3
795+
- uses: actions/checkout@v6
796+
- uses: ./.github/actions/setup-prebuild
789797
- name: Install nightly for cbindgen macro expansion
790798
run: rustup toolchain install $NIGHTLY_TOOLCHAIN
791-
- uses: ./.github/actions/setup-flatc
792799
- name: "regenerate all .fbs/.proto Rust code"
793800
run: |
794801
cargo xtask generate-fbs
@@ -816,7 +823,7 @@ jobs:
816823
runs-on: ${{ matrix.target.runs-on }}
817824
container:
818825
image: "ubuntu:20.04"
819-
timeout-minutes: 120
826+
timeout-minutes: 40
820827
strategy:
821828
fail-fast: false
822829
matrix:
@@ -841,7 +848,7 @@ jobs:
841848

842849
rust-publish-dry-run:
843850
name: "Rust publish dry-run"
844-
timeout-minutes: 120
851+
timeout-minutes: 40
845852
runs-on: >-
846853
${{ github.repository == 'vortex-data/vortex'
847854
&& format('runs-on={0}/runner=amd64-xsmall/image=ubuntu24-full-x64-pre-v2/tag=rust-publish-dry-run', github.run_id)
@@ -854,7 +861,7 @@ jobs:
854861
- uses: actions/checkout@v6
855862
- uses: ./.github/actions/setup-prebuild
856863
- name: Install cargo-edit
857-
uses: taiki-e/cache-cargo-install-action@24c4eaa867646941dd8cd6f08c1497ea68d732ba
864+
uses: taiki-e/cache-cargo-install-action@59027ebf20a9617c4e819eb53ccd2673cb162b89
858865
with:
859866
tool: cargo-edit
860867
- name: Set Version

0 commit comments

Comments
 (0)