fix types

Signed-off-by: Daniel King <dan@spiraldb.com>

Author: danking

vortex-python/python/vortex/_lib/store/__init__.pyi

@@ -130,13 +130,13 @@ class LocalStore:
     ```
     """
 
-    def __init__(
+    def __new__(
         self,
         prefix: str | Path | None = None,
         *,
         automatic_cleanup: bool = False,
         mkdir: bool = False,
-    ) -> None:
+    ) -> Self:
         """Create a new LocalStore.
 
         Args:

vortex-python/python/vortex/_lib/store/_aws.pyi

@@ -457,8 +457,8 @@ class S3Store:
     set in the environment.
     """
 
-    def __init__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "bucket"
-        self,
+    def __new__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "bucket"
+        cls,
         bucket: str | None = None,
         *,
         prefix: str | None = None,
@@ -467,7 +467,7 @@ class S3Store:
         retry_config: RetryConfig | None = None,
         credential_provider: S3CredentialProvider | None = None,
         **kwargs: Unpack[S3Config],  # type: ignore # noqa: PGH003 (bucket key overlaps with positional arg)
-    ) -> None:
+    ) -> Self:
         """Create a new S3Store.
 
         Args:

vortex-python/python/vortex/_lib/store/_azure.pyi

@@ -315,8 +315,8 @@ class AzureStore:
     [`AzureConfig`][vortex.store.AzureConfig] for valid environment variables.
     """
 
-    def __init__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "container_name"
-        self,
+    def __new__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "container_name"
+        cls,
         container_name: str | None = None,
         *,
         prefix: str | None = None,
@@ -325,7 +325,7 @@ class AzureStore:
         retry_config: RetryConfig | None = None,
         credential_provider: AzureCredentialProvider | None = None,
         **kwargs: Unpack[AzureConfig],  # type: ignore # noqa: PGH003 (container_name key overlaps with positional arg)
-    ) -> None:
+    ) -> Self:
         """Construct a new AzureStore.
 
         Args:

vortex-python/python/vortex/_lib/store/_gcs.pyi

@@ -134,8 +134,8 @@ class GCSStore:
     [here](https://cloud.google.com/docs/authentication/application-default-credentials).
     """
 
-    def __init__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "bucket"
-        self,
+    def __new__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "bucket"
+        cls,
         bucket: str | None = None,
         *,
         prefix: str | None = None,
@@ -144,7 +144,7 @@ class GCSStore:
         retry_config: RetryConfig | None = None,
         credential_provider: GCSCredentialProvider | None = None,
         **kwargs: Unpack[GCSConfig],  # type: ignore # noqa: PGH003 (bucket key overlaps with positional arg)
-    ) -> None:
+    ) -> Self:
         """Construct a new GCSStore.
 
         Args:

vortex-python/python/vortex/_lib/store/_http.pyi

@@ -9,13 +9,13 @@ from ._retry import RetryConfig
 class HTTPStore:
     """Configure a connection to a generic HTTP server."""
 
-    def __init__(
+    def __new__(
         self,
         url: str,
         *,
         client_options: ClientConfig | None = None,
         retry_config: RetryConfig | None = None,
-    ) -> None:
+    ) -> Self:
         """Construct a new HTTPStore from a URL.
 
         Any path on the URL will be assigned as the `prefix` for the store. So if you

vortex-python/python/vortex/store/__init__.py

@@ -116,13 +116,13 @@ def from_url(  # type: ignore[misc] # docstring in pyi file
         kwargs: per-store configuration passed down to store-specific builders.
 
     """
-    return _store.from_url(
+    return _store.from_url(  # pyright: ignore[reportCallIssue, reportUnknownVariableType]
         url,
-        config=config,
+        config=config,  # pyright: ignore[reportArgumentType]
         client_options=client_options,
         retry_config=retry_config,
-        credential_provider=credential_provider,
-        **kwargs,
+        credential_provider=credential_provider,  # pyright: ignore[reportArgumentType]
+        **kwargs,  # pyright: ignore[reportArgumentType]
     )
 
 

vortex-python/python/vortex/store/_aws.py

@@ -439,7 +439,7 @@ def __new__(
         retry_config: RetryConfig | None = None,
         credential_provider: S3CredentialProvider | None = None,
         **kwargs: Unpack[S3Config],  # pyright: ignore[reportGeneralTypeIssues]
-    ):
+    ) -> Self:
         """Create a new S3Store.
 
         Args:
@@ -459,15 +459,15 @@ def __new__(
             S3Store
 
         """
-        return super().__new__(
+        return super().__new__(  # pyright: ignore[reportUnknownVariableType]
             cls,
             bucket,
             prefix=prefix,
             config=config,
             client_options=client_options,
             retry_config=retry_config,
             credential_provider=credential_provider,
-            **kwargs,  # pyright: ignore[reportCallIssue]
+            **kwargs,  # pyright: ignore[reportCallIssue]  bucket appears in both S3Config and explicitly above
         )
 
     @override

vortex-python/python/vortex/store/_azure.py

@@ -274,7 +274,7 @@ def __new__(  # type: ignore[misc] # Overlap between argument names and ** Typed
         retry_config: RetryConfig | None = None,
         credential_provider: AzureCredentialProvider | None = None,
         **kwargs: Unpack[AzureConfig],  # pyright: ignore[reportGeneralTypeIssues]
-    ):
+    ) -> Self:
         """Construct a new AzureStore.
 
         Args:
@@ -294,7 +294,7 @@ def __new__(  # type: ignore[misc] # Overlap between argument names and ** Typed
             AzureStore
 
         """
-        return super().__new__(
+        return super().__new__(  # pyright: ignore[reportUnknownVariableType]
             cls,
             container_name,
             prefix=prefix,

vortex-python/python/vortex/store/_gcs.py

@@ -118,7 +118,7 @@ def __new__(  # type: ignore[misc] # Overlap between argument names and ** Typed
         retry_config: RetryConfig | None = None,
         credential_provider: GCSCredentialProvider | None = None,
         **kwargs: Unpack[GCSConfig],  # pyright: ignore[reportGeneralTypeIssues]
-    ):
+    ) -> Self:
         """Construct a new GCSStore.
 
         Args:
@@ -138,7 +138,7 @@ def __new__(  # type: ignore[misc] # Overlap between argument names and ** Typed
             GCSStore
 
         """
-        return super().__new__(  # type: ignore[misc] # Overlap between argument names and ** TypedDict items: "bucket"
+        return super().__new__(  # pyright: ignore[reportUnknownVariableType]
             cls,
             bucket,
             prefix=prefix,

vortex-python/python/vortex/store/_local.py

@@ -27,7 +27,7 @@ def __new__(
         *,
         automatic_cleanup: bool = False,
         mkdir: bool = False,
-    ):
+    ) -> Self:
         """Create a new LocalStore.
 
         Args: