fix: resolve CI lint failures for array_slots macro PR

- Remove unused imports of DictArrayExt, ALPArraySlotsExt where SlotsExt
  provides the needed methods
- Fix base_array() -> inner() rename in fastlanes plugin test
- Remove dead downcast_slot function and commented-out code
- Fix taplo formatting in workspace Cargo.toml
- Regenerate public-api.lock files

Signed-off-by: Joe Isaacs <joe@spiraldb.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: joseph-isaacs

encodings/alp/public-api.lock

@@ -338,6 +338,8 @@ impl<'a> vortex_alp::ALPSlotsView<'a>
 
 pub fn vortex_alp::ALPSlotsView<'a>::from_slots(slots: &'a [core::option::Option<vortex_array::array::erased::ArrayRef>]) -> Self
 
+pub fn vortex_alp::ALPSlotsView<'a>::to_owned(&self) -> vortex_alp::ALPSlots
+
 impl<'a> core::clone::Clone for vortex_alp::ALPSlotsView<'a>
 
 pub fn vortex_alp::ALPSlotsView<'a>::clone(&self) -> vortex_alp::ALPSlotsView<'a>

encodings/fastlanes/public-api.lock

@@ -248,6 +248,34 @@ pub vortex_fastlanes::BitPackedDataParts::patches: core::option::Option<vortex_a
 
 pub vortex_fastlanes::BitPackedDataParts::validity: vortex_array::validity::Validity
 
+pub struct vortex_fastlanes::BitPackedSlots
+
+pub vortex_fastlanes::BitPackedSlots::patch_chunk_offsets: core::option::Option<vortex_array::array::erased::ArrayRef>
+
+pub vortex_fastlanes::BitPackedSlots::patch_indices: core::option::Option<vortex_array::array::erased::ArrayRef>
+
+pub vortex_fastlanes::BitPackedSlots::patch_values: core::option::Option<vortex_array::array::erased::ArrayRef>
+
+pub vortex_fastlanes::BitPackedSlots::validity_child: core::option::Option<vortex_array::array::erased::ArrayRef>
+
+impl vortex_fastlanes::BitPackedSlots
+
+pub const vortex_fastlanes::BitPackedSlots::COUNT: usize
+
+pub const vortex_fastlanes::BitPackedSlots::NAMES: [&'static str; 4]
+
+pub const vortex_fastlanes::BitPackedSlots::PATCH_CHUNK_OFFSETS: usize
+
+pub const vortex_fastlanes::BitPackedSlots::PATCH_INDICES: usize
+
+pub const vortex_fastlanes::BitPackedSlots::PATCH_VALUES: usize
+
+pub const vortex_fastlanes::BitPackedSlots::VALIDITY_CHILD: usize
+
+pub fn vortex_fastlanes::BitPackedSlots::from_slots(slots: alloc::vec::Vec<core::option::Option<vortex_array::array::erased::ArrayRef>>) -> Self
+
+pub fn vortex_fastlanes::BitPackedSlots::into_slots(self) -> alloc::vec::Vec<core::option::Option<vortex_array::array::erased::ArrayRef>>
+
 pub struct vortex_fastlanes::Delta
 
 impl vortex_fastlanes::Delta
@@ -544,7 +572,7 @@ pub fn vortex_fastlanes::RLEData::array_hash<H: core::hash::Hasher>(&self, state
 
 pub static vortex_fastlanes::USE_EXPERIMENTAL_PATCHES: std::sync::lazy_lock::LazyLock<bool>
 
-pub trait vortex_fastlanes::BitPackedArrayExt: vortex_array::array::typed::TypedArrayRef<vortex_fastlanes::BitPacked>
+pub trait vortex_fastlanes::BitPackedArrayExt: vortex_fastlanes::BitPackedArraySlotsExt
 
 pub fn vortex_fastlanes::BitPackedArrayExt::bit_width(&self) -> u8
 
@@ -554,20 +582,12 @@ pub fn vortex_fastlanes::BitPackedArrayExt::packed(&self) -> &vortex_array::buff
 
 pub fn vortex_fastlanes::BitPackedArrayExt::packed_slice<T: vortex_array::dtype::ptype::NativePType + fastlanes::bitpacking::BitPacking>(&self) -> &[T]
 
-pub fn vortex_fastlanes::BitPackedArrayExt::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
-
-pub fn vortex_fastlanes::BitPackedArrayExt::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
-
-pub fn vortex_fastlanes::BitPackedArrayExt::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
-
 pub fn vortex_fastlanes::BitPackedArrayExt::patches(&self) -> core::option::Option<vortex_array::patches::Patches>
 
 pub fn vortex_fastlanes::BitPackedArrayExt::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
 
 pub fn vortex_fastlanes::BitPackedArrayExt::validity(&self) -> vortex_array::validity::Validity
 
-pub fn vortex_fastlanes::BitPackedArrayExt::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
-
 pub fn vortex_fastlanes::BitPackedArrayExt::validity_mask(&self) -> vortex_mask::Mask
 
 impl<T: vortex_array::array::typed::TypedArrayRef<vortex_fastlanes::BitPacked>> vortex_fastlanes::BitPackedArrayExt for T
@@ -580,22 +600,38 @@ pub fn T::packed(&self) -> &vortex_array::buffer::BufferHandle
 
 pub fn T::packed_slice<T: vortex_array::dtype::ptype::NativePType + fastlanes::bitpacking::BitPacking>(&self) -> &[T]
 
+pub fn T::patches(&self) -> core::option::Option<vortex_array::patches::Patches>
+
+pub fn T::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
+
+pub fn T::validity(&self) -> vortex_array::validity::Validity
+
+pub fn T::validity_mask(&self) -> vortex_mask::Mask
+
+pub trait vortex_fastlanes::BitPackedArraySlotsExt: vortex_array::array::typed::TypedArrayRef<vortex_fastlanes::BitPacked>
+
+pub fn vortex_fastlanes::BitPackedArraySlotsExt::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArraySlotsExt::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArraySlotsExt::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArraySlotsExt::slots_view(&self) -> vortex_fastlanes::bitpacking::array::BitPackedSlotsView<'_>
+
+pub fn vortex_fastlanes::BitPackedArraySlotsExt::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+impl<T: vortex_array::array::typed::TypedArrayRef<vortex_fastlanes::BitPacked>> vortex_fastlanes::BitPackedArraySlotsExt for T
+
 pub fn T::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
 
 pub fn T::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
 
 pub fn T::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
 
-pub fn T::patches(&self) -> core::option::Option<vortex_array::patches::Patches>
-
-pub fn T::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
-
-pub fn T::validity(&self) -> vortex_array::validity::Validity
+pub fn T::slots_view(&self) -> vortex_fastlanes::bitpacking::array::BitPackedSlotsView<'_>
 
 pub fn T::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
 
-pub fn T::validity_mask(&self) -> vortex_mask::Mask
-
 pub trait vortex_fastlanes::FoRArrayExt: vortex_array::array::typed::TypedArrayRef<vortex_fastlanes::FoR>
 
 pub fn vortex_fastlanes::FoRArrayExt::encoded(&self) -> &vortex_array::array::erased::ArrayRef

encodings/fastlanes/src/bitpacking/plugin.rs

@@ -92,7 +92,7 @@ mod tests {
     use vortex_array::IntoArray;
     use vortex_array::arrays::PatchedArray;
     use vortex_array::arrays::PrimitiveArray;
-    use vortex_array::arrays::patched::PatchedArrayExt;
+    use vortex_array::arrays::patched::PatchedArraySlotsExt;
     use vortex_array::buffer::BufferHandle;
     use vortex_array::session::ArraySession;
     use vortex_array::session::ArraySessionExt;
@@ -150,7 +150,7 @@ mod tests {
             .map_err(|a| vortex_err!("Expected Patched, got {}", a.encoding_id()))?;
 
         let inner_bitpacked: BitPackedArray = patched
-            .base_array()
+            .inner()
             .clone()
             .try_downcast()
             .map_err(|a| vortex_err!("Expected inner BitPacked, got {}", a.encoding_id()))?;

vortex-array/public-api.lock

@@ -2156,6 +2156,8 @@ impl<'a> vortex_array::arrays::dict::DictSlotsView<'a>
 
 pub fn vortex_array::arrays::dict::DictSlotsView<'a>::from_slots(slots: &'a [core::option::Option<vortex_array::ArrayRef>]) -> Self
 
+pub fn vortex_array::arrays::dict::DictSlotsView<'a>::to_owned(&self) -> vortex_array::arrays::dict::DictSlots
+
 impl<'a> core::clone::Clone for vortex_array::arrays::dict::DictSlotsView<'a>
 
 pub fn vortex_array::arrays::dict::DictSlotsView<'a>::clone(&self) -> vortex_array::arrays::dict::DictSlotsView<'a>
@@ -3524,6 +3526,8 @@ impl<'a> vortex_array::arrays::patched::PatchedSlotsView<'a>
 
 pub fn vortex_array::arrays::patched::PatchedSlotsView<'a>::from_slots(slots: &'a [core::option::Option<vortex_array::ArrayRef>]) -> Self
 
+pub fn vortex_array::arrays::patched::PatchedSlotsView<'a>::to_owned(&self) -> vortex_array::arrays::patched::PatchedSlots
+
 impl<'a> core::clone::Clone for vortex_array::arrays::patched::PatchedSlotsView<'a>
 
 pub fn vortex_array::arrays::patched::PatchedSlotsView<'a>::clone(&self) -> vortex_array::arrays::patched::PatchedSlotsView<'a>

vortex-array/src/arrays/patched/vtable/mod.rs

@@ -260,22 +260,10 @@ impl VTable for Patched {
 
         let len = array.len();
 
-        fn downcast_slot(slot: ArrayRef) -> PrimitiveArray {
-            slot.try_downcast::<Primitive>()
-                .ok()
-                .vortex_expect("slot must be primitive")
-        }
-
         let n_lanes = array.n_lanes;
         let offset = array.offset;
         let slots = match array.try_into_parts() {
-            Ok(parts) => {
-                PatchedSlots::from_slots(parts.slots)
-                // let inner = downcast_slot(take_slot(&mut parts.slots, INNER_SLOT));
-                // let lane_offsets = downcast_slot(take_slot(&mut parts.slots, LANE_OFFSETS_SLOT));
-                // let indices = downcast_slot(take_slot(&mut parts.slots, INDICES_SLOT));
-                // let values = downcast_slot(take_slot(&mut parts.slots, VALUES_SLOT));
-            }
+            Ok(parts) => PatchedSlots::from_slots(parts.slots),
             Err(array) => PatchedSlotsView::from_slots(array.slots()).to_owned(),
         };
 

vortex-compressor/src/builtins/dict/float.rs

@@ -238,7 +238,6 @@ mod tests {
     use vortex_array::ToCanonical;
     use vortex_array::arrays::BoolArray;
     use vortex_array::arrays::PrimitiveArray;
-    use vortex_array::arrays::dict::DictArrayExt;
     use vortex_array::arrays::dict::DictArraySlotsExt;
     use vortex_array::assert_arrays_eq;
     use vortex_array::validity::Validity;

vortex-compressor/src/builtins/dict/integer.rs

@@ -244,7 +244,6 @@ mod tests {
     use vortex_array::ToCanonical;
     use vortex_array::arrays::BoolArray;
     use vortex_array::arrays::PrimitiveArray;
-    use vortex_array::arrays::dict::DictArrayExt;
     use vortex_array::arrays::dict::DictArraySlotsExt;
     use vortex_array::assert_arrays_eq;
     use vortex_array::validity::Validity;

vortex-file/src/tests.rs

@@ -24,7 +24,6 @@ use vortex_array::arrays::StructArray;
 use vortex_array::arrays::TemporalArray;
 use vortex_array::arrays::VarBinArray;
 use vortex_array::arrays::VarBinViewArray;
-use vortex_array::arrays::dict::DictArrayExt;
 use vortex_array::arrays::dict::DictArraySlotsExt;
 use vortex_array::arrays::struct_::StructArrayExt;
 use vortex_array::assert_arrays_eq;