remove check for ArrayPlugin encoding ID match (#7427)

## Summary

When deserializing an array encoded using the experimental patched
encoding `ArrayPlugin`, reads can fail b/c of this assertion.

`ArrayPlugin`s can/should be able to support multiple codecs

The alternative to this is to change ArrayPlugin to return a set of
ArrayId's that it covers, rather than a single ID.

---------

Signed-off-by: Andrew Duffy <andrew@a10y.dev>

Author: a10y

encodings/fastlanes/src/bitpacking/plugin.rs

@@ -82,6 +82,10 @@ impl ArrayPlugin for BitPackedPatchedPlugin {
 
         Ok(patched.into_array())
     }
+
+    fn is_supported_encoding(&self, id: &ArrayId) -> bool {
+        id == &BitPacked::ID || id == &Patched.id()
+    }
 }
 
 #[cfg(test)]

vortex-array/public-api.lock

@@ -19412,6 +19412,8 @@ pub fn vortex_array::vtable::ArrayPlugin::deserialize(&self, dtype: &vortex_arra
 
 pub fn vortex_array::vtable::ArrayPlugin::id(&self) -> vortex_array::ArrayId
 
+pub fn vortex_array::vtable::ArrayPlugin::is_supported_encoding(&self, id: &vortex_array::ArrayId) -> bool
+
 pub fn vortex_array::vtable::ArrayPlugin::serialize(&self, array: &vortex_array::ArrayRef, session: &vortex_session::VortexSession) -> vortex_error::VortexResult<core::option::Option<alloc::vec::Vec<u8>>>
 
 impl<V: vortex_array::VTable> vortex_array::ArrayPlugin for V
@@ -19420,6 +19422,8 @@ pub fn V::deserialize(&self, dtype: &vortex_array::dtype::DType, len: usize, met
 
 pub fn V::id(&self) -> arcref::ArcRef<str>
 
+pub fn V::is_supported_encoding(&self, id: &vortex_array::ArrayId) -> bool
+
 pub fn V::serialize(&self, array: &vortex_array::ArrayRef, session: &vortex_session::VortexSession) -> core::result::Result<core::option::Option<alloc::vec::Vec<u8>>, vortex_error::VortexError>
 
 pub trait vortex_array::vtable::ArrayVTable: 'static + core::clone::Clone + core::marker::Sized + core::marker::Send + core::marker::Sync + core::fmt::Debug
@@ -23056,6 +23060,10 @@ pub fn vortex_array::ArrayPlugin::id(&self) -> vortex_array::ArrayId
 
 pub fn vortex_array::ArrayPlugin::id(&self) -> vortex_array::ArrayId
 
+pub fn vortex_array::ArrayPlugin::is_supported_encoding(&self, id: &vortex_array::ArrayId) -> bool
+
+pub fn vortex_array::ArrayPlugin::is_supported_encoding(&self, id: &vortex_array::ArrayId) -> bool
+
 pub fn vortex_array::ArrayPlugin::serialize(&self, array: &vortex_array::ArrayRef, session: &vortex_session::VortexSession) -> vortex_error::VortexResult<core::option::Option<alloc::vec::Vec<u8>>>
 
 pub fn vortex_array::ArrayPlugin::serialize(&self, array: &vortex_array::ArrayRef, session: &vortex_session::VortexSession) -> vortex_error::VortexResult<core::option::Option<alloc::vec::Vec<u8>>>
@@ -23072,6 +23080,10 @@ pub fn V::id(&self) -> arcref::ArcRef<str>
 
 pub fn V::id(&self) -> arcref::ArcRef<str>
 
+pub fn V::is_supported_encoding(&self, id: &vortex_array::ArrayId) -> bool
+
+pub fn V::is_supported_encoding(&self, id: &vortex_array::ArrayId) -> bool
+
 pub fn V::serialize(&self, array: &vortex_array::ArrayRef, session: &vortex_session::VortexSession) -> core::result::Result<core::option::Option<alloc::vec::Vec<u8>>, vortex_error::VortexError>
 
 pub fn V::serialize(&self, array: &vortex_array::ArrayRef, session: &vortex_session::VortexSession) -> core::result::Result<core::option::Option<alloc::vec::Vec<u8>>, vortex_error::VortexError>

vortex-array/src/array/plugin.rs

@@ -27,6 +27,9 @@ pub type ArrayPluginRef = Arc<dyn ArrayPlugin>;
 /// [`deserialize`]: ArrayPlugin::deserialize
 pub trait ArrayPlugin: 'static + Send + Sync {
     /// Returns the ID for this array encoding.
+    ///
+    /// During serde, this is the key the registry uses to find
+    /// this plugin instance and call the appropriate method on it.
     fn id(&self) -> ArrayId;
 
     /// Serialize the array metadata.
@@ -49,6 +52,14 @@ pub trait ArrayPlugin: 'static + Send + Sync {
         children: &dyn ArrayChildren,
         session: &VortexSession,
     ) -> VortexResult<ArrayRef>;
+
+    /// Can this plugin emit an array with the given encoding.
+    ///
+    /// By default, this is just the [ID][Self::id] of the plugin, but
+    /// can be overridden if this plugin instance supports reading/writing multiple arrays.
+    fn is_supported_encoding(&self, id: &ArrayId) -> bool {
+        self.id() == *id
+    }
 }
 
 impl std::fmt::Debug for dyn ArrayPlugin {

vortex-array/src/serde.rs

@@ -367,9 +367,9 @@ impl SerializedArray {
             decoded.dtype(),
             dtype,
         );
-        assert_eq!(
-            decoded.encoding_id(),
-            encoding_id,
+
+        assert!(
+            plugin.is_supported_encoding(&decoded.encoding_id()),
             "Array decoded from {} has incorrect encoding {}",
             encoding_id,
             decoded.encoding_id(),