Skip to content

Commit 2912d41

Browse files
committed
avoid duplicate outputs for s3 benches
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
1 parent ae9f875 commit 2912d41

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/sql-benchmarks.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ jobs:
260260
comment-tag: bench-pr-comment-${{ matrix.id }}
261261

262262
- name: Compare file sizes
263-
if: inputs.mode == 'pr'
263+
if: inputs.mode == 'pr' && matrix.remote_storage == null
264264
shell: bash
265265
run: |
266266
set -Eeu -o pipefail -x
@@ -303,7 +303,7 @@ jobs:
303303
cat sizes-comment.md >> $GITHUB_STEP_SUMMARY
304304
305305
- name: Comment PR with file sizes
306-
if: inputs.mode == 'pr' && github.event.pull_request.head.repo.fork == false
306+
if: inputs.mode == 'pr' && matrix.remote_storage == null && github.event.pull_request.head.repo.fork == false
307307
uses: thollander/actions-comment-pull-request@v3
308308
with:
309309
file-path: sizes-comment.md
@@ -326,7 +326,7 @@ jobs:
326326
bash scripts/cat-s3.sh vortex-ci-benchmark-results data.json.gz results.json
327327
328328
- name: Upload File Sizes
329-
if: inputs.mode == 'develop'
329+
if: inputs.mode == 'develop' && matrix.remote_storage == null
330330
shell: bash
331331
run: |
332332
uv run --no-project scripts/capture-file-sizes.py \

0 commit comments

Comments
 (0)