Hoist take validity outside type dispatch

Signed-off-by: Daniel King <dan@spiraldb.com>

Author: danking

vortex-array/src/arrays/decimal/compute/take.rs

@@ -63,6 +63,7 @@ fn take_piecewise_sequence(
     let Some((starts, lengths)) = execute_unit_multiplier_index_arrays(indices, ctx)? else {
         return Ok(None);
     };
+    let validity = array.validity()?.take(indices_ref)?;
     match_each_decimal_value_type!(array.values_type(), |D| {
         match_each_unsigned_integer_ptype!(starts.ptype(), |S| {
             match_each_unsigned_integer_ptype!(lengths.ptype(), |L| {
@@ -72,7 +73,6 @@ fn take_piecewise_sequence(
                     array.buffer::<D>().as_slice(),
                     indices_ref.len(),
                 )?;
-                let validity = array.validity()?.take(indices_ref)?;
 
                 // SAFETY: contiguous gather preserves the decimal dtype and value representation.
                 Ok(Some(

vortex-array/src/arrays/list/compute/take.rs

@@ -194,6 +194,7 @@ where
     validate_index_ranges(array.len(), starts, lengths, indices_ref.len())?;
     let total_elements =
         piecewise_list_elements_len(array.elements().len(), offsets, starts, lengths)?;
+    let validity = array.validity()?.take(indices_ref)?;
 
     match_smallest_offset_type!(total_elements, |OutputOffset| {
         let gathered = gather_piecewise_list::<S, L, Offset, OutputOffset>(
@@ -204,7 +205,6 @@ where
             indices_ref.len(),
             total_elements,
         )?;
-        let validity = array.validity()?.take(indices_ref)?;
 
         // SAFETY: output offsets are rebuilt from valid monotonic source offsets; output elements
         // are exactly the gathered child ranges referenced by those offsets; validity has one bit

vortex-array/src/arrays/primitive/compute/take/mod.rs

@@ -143,6 +143,7 @@ fn take_piecewise_sequence(
     let Some((starts, lengths)) = execute_unit_multiplier_index_arrays(indices, ctx)? else {
         return Ok(None);
     };
+    let validity = array.validity()?.take(indices_ref)?;
     match_each_native_ptype!(array.ptype(), |T| {
         match_each_unsigned_integer_ptype!(starts.ptype(), |S| {
             match_each_unsigned_integer_ptype!(lengths.ptype(), |L| {
@@ -152,7 +153,6 @@ fn take_piecewise_sequence(
                     lengths.as_slice::<L>(),
                     indices_ref.len(),
                 )?;
-                let validity = array.validity()?.take(indices_ref)?;
                 Ok(Some(PrimitiveArray::new(values, validity).into_array()))
             })
         })