Skip to content

Commit 2fe5929

Browse files
committed
Fix clickhouse grep anchor in run-sql-bench.sh
Remove ^ anchor from clickhouse grep patterns to match targets regardless of position in the comma-separated string, consistent with the lance guard pattern. Signed-off-by: fastio <pengjian.uestc@gmail.com>
1 parent c82e0c0 commit 2fe5929

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

.github/scripts/run-sql-bench.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ if $is_remote && echo "$targets" | grep -q 'lance'; then
7171
exit 1
7272
fi
7373

74+
# ClickHouse on remote storage is not supported. clickhouse-local reads local files only.
75+
if $is_remote && echo "$targets" | grep -q 'clickhouse:'; then
76+
echo "ERROR: ClickHouse benchmarks are not supported for remote storage."
77+
echo "Remove 'clickhouse:' targets for benchmark '${benchmark_id:-unknown}'."
78+
exit 1
79+
fi
80+
7481
# Extract formats for each engine from the targets string.
7582
# Example input: "datafusion:parquet,datafusion:vortex,datafusion:lance,duckdb:parquet"
7683
#
@@ -84,7 +91,7 @@ fi
8491
df_formats=$(echo "$targets" | tr ',' '\n' | (grep '^datafusion:' | grep -v ':lance$' || true) | sed 's/datafusion://' | tr '\n' ',' | sed 's/,$//')
8592
ddb_formats=$(echo "$targets" | tr ',' '\n' | (grep '^duckdb:' || true) | sed 's/duckdb://' | tr '\n' ',' | sed 's/,$//')
8693
has_lance=$(echo "$targets" | grep -q 'datafusion:lance' && echo "true" || echo "false")
87-
has_clickhouse=$(echo "$targets" | grep -q '^clickhouse:' && echo "true" || echo "false")
94+
has_clickhouse=$(echo "$targets" | grep -q 'clickhouse:' && echo "true" || echo "false")
8895

8996
# Build options string.
9097
opts=""

0 commit comments

Comments
 (0)