fixes

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Author: AdamGS

encodings/sparse/src/canonical.rs

@@ -50,6 +50,7 @@ use vortex_buffer::buffer_mut;
 use vortex_error::VortexError;
 use vortex_error::VortexExpect;
 use vortex_error::VortexResult;
+use vortex_error::vortex_bail;
 use vortex_error::vortex_panic;
 
 use crate::ConstantArray;
@@ -117,7 +118,7 @@ pub(super) fn execute_sparse(
             execute_sparse_fixed_size_list(array, *nullability, ctx)?
         }
         DType::Extension(_ext_dtype) => todo!(),
-        DType::Variant => todo!(),
+        DType::Variant => vortex_bail!("Sparse canonicalization does not support Variant"),
     })
 }
 

vortex-array/src/arrays/variant/mod.rs

@@ -10,7 +10,7 @@ use crate::stats::ArrayStats;
 /// The canonical in-memory representation of variant (semi-structured) data.
 ///
 /// Wraps a single child array that contains the actual variant-encoded data
-/// (e.g. a [`ParquetVariantArray`] or any other variant encoding).
+/// (e.g. a `ParquetVariantArray` or any other variant encoding).
 #[derive(Clone, Debug)]
 pub struct VariantArray {
     child: ArrayRef,

vortex-datafusion/src/convert/scalars.rs

@@ -101,6 +101,7 @@ impl TryToDataFusion<ScalarValue> for Scalar {
                     }
                 }
             }
+            // SAFETY: By construction Utf8 scalar values are utf8.
             DType::Utf8(_) => ScalarValue::Utf8(self.as_utf8().value().cloned().map(|s| unsafe {
                 String::from_utf8_unchecked(Vec::<u8>::from(s.into_inner().into_inner()))
             })),

vortex-duckdb/src/convert/scalar.rs

@@ -79,7 +79,9 @@ impl ToDuckDBScalar for Scalar {
             DType::Utf8(_) => self.as_utf8().try_to_duckdb_scalar(),
             DType::Binary(_) => self.as_binary().try_to_duckdb_scalar(),
             DType::Struct(..) | DType::List(..) | DType::FixedSizeList(..) => todo!(),
-            DType::Variant => todo!(),
+            DType::Variant => {
+                vortex_bail!("Vortex Variant scalars aren't supported in DuckDB")
+            }
         }
     }
 }