IsSortedKernel

Signed-off-by: Nicholas Gates <nick@nickgates.com>

Author: gatesn

vortex-array/src/aggregate_fn/fns/is_constant/mod.rs

@@ -10,6 +10,7 @@ pub mod primitive;
 mod struct_;
 mod varbin;
 
+use vortex_error::VortexExpect;
 use vortex_error::VortexResult;
 use vortex_mask::Mask;
 
@@ -234,9 +235,10 @@ impl IsConstantPartial {
     }
 }
 
+static NAMES: std::sync::LazyLock<FieldNames> =
+    std::sync::LazyLock::new(|| FieldNames::from(["is_constant", "value"]));
+
 pub fn make_is_constant_partial_dtype(element_dtype: &DType) -> DType {
-    static NAMES: std::sync::LazyLock<FieldNames> =
-        std::sync::LazyLock::new(|| FieldNames::from(["is_constant", "value"]));
     DType::Struct(
         StructFields::new(
             NAMES.clone(),
@@ -409,8 +411,7 @@ impl AggregateFnVTable for IsConstant {
     }
 
     fn finalize(&self, partials: ArrayRef) -> VortexResult<ArrayRef> {
-        // TODO: extract is_constant field from struct array
-        Ok(partials)
+        partials.get_item(NAMES.get(0).vortex_expect("out of bounds").clone())
     }
 
     fn finalize_scalar(&self, partial: Scalar) -> VortexResult<Scalar> {

vortex-array/src/compute/is_constant.rs

@@ -8,6 +8,7 @@ use vortex_error::VortexResult;
 use crate::ArrayRef;
 use crate::LEGACY_SESSION;
 use crate::VortexSessionExecute;
+use crate::compute::Options;
 
 /// Computes whether an array has constant values.
 ///
@@ -59,7 +60,7 @@ impl Default for IsConstantOpts {
     }
 }
 
-impl super::Options for IsConstantOpts {
+impl Options for IsConstantOpts {
     fn as_any(&self) -> &dyn Any {
         self
     }