fix[array]: get_item reduce + struct

joseph-isaacs · joseph-isaacs · commit 38efa22bcc12 · 2026-05-11T17:16:16.000+01:00
Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/vortex-array/src/arrays/struct_/compute/rules.rs b/vortex-array/src/arrays/struct_/compute/rules.rs
@@ -109,7 +109,7 @@ impl ArrayParentReduceRule<Struct> for StructGetItemRule {
             Validity::AllInvalid => {
                 // If everything is invalid, the field is also all invalid
                 Ok(Some(
-                    ConstantArray::new(Scalar::null(field.dtype().clone()), field.len())
+                    ConstantArray::new(Scalar::null(field.dtype().as_nullable()), field.len())
                         .into_array(),
                 ))
             }
diff --git a/vortex-array/src/scalar_fn/fns/get_item.rs b/vortex-array/src/scalar_fn/fns/get_item.rs
@@ -258,7 +258,6 @@ mod tests {
     }
 
     #[test]
-    #[should_panic = "Cannot create null scalar with non-nullable dtype i32"]
     fn get_nullable_field() {
         let st = StructArray::try_new(
             FieldNames::from(["a"]),

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ impl ArrayParentReduceRule<Struct> for StructGetItemRule {`
`109`	`109`	`Validity::AllInvalid => {`
`110`	`110`	`// If everything is invalid, the field is also all invalid`
`111`	`111`	`Ok(Some(`
`112`		`- ConstantArray::new(Scalar::null(field.dtype().clone()), field.len())`
	`112`	`+ ConstantArray::new(Scalar::null(field.dtype().as_nullable()), field.len())`
`113`	`113`	`.into_array(),`
`114`	`114`	`))`
`115`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,6 @@ mod tests {`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`#[test]`
`261`		`- #[should_panic = "Cannot create null scalar with non-nullable dtype i32"]`
`262`	`261`	`fn get_nullable_field() {`
`263`	`262`	`let st = StructArray::try_new(`
`264`	`263`	`FieldNames::from(["a"]),`