Skip to content

Commit 41d4bf6

Browse files
committed
Use cargo-zigbuild to link against old libc
Signed-off-by: Robert Kruszewski <github@robertk.io>
1 parent 8b09d0c commit 41d4bf6

3 files changed

Lines changed: 44 additions & 44 deletions

File tree

.github/actions/prepare-java-linux/action.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

.github/workflows/package.yml

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -106,35 +106,44 @@ jobs:
106106
if-no-files-found: error
107107

108108
prepare-java-linux:
109-
runs-on: ${{ matrix.target.runs-on }}
110-
container:
111-
image: "ubuntu:20.04"
112109
timeout-minutes: 30
113110
strategy:
114111
fail-fast: false
115112
matrix:
116-
target:
117-
- { os: ubuntu, runs-on: "ubuntu-24.04-arm", target: aarch64-unknown-linux-gnu }
118-
- { os: ubuntu, runs-on: "ubuntu-24.04", target: x86_64-unknown-linux-gnu }
113+
include:
114+
- target: x86_64-unknown-linux-gnu
115+
runner: runs-on=${{ github.run_id }}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=prepare-java-linux-amd64
116+
fallback_runner: ubuntu-24.04
117+
- target: aarch64-unknown-linux-gnu
118+
runner: runs-on=${{ github.run_id }}/runner=arm64-medium/image=ubuntu24-full-arm64-pre-v2/tag=prepare-java-linux-arm64
119+
fallback_runner: ubuntu-24.04-arm
120+
runs-on: >-
121+
${{ github.repository == 'vortex-data/vortex'
122+
&& matrix.runner
123+
|| matrix.fallback_runner }}
119124
steps:
125+
- uses: runs-on/action@v2
126+
if: github.repository == 'vortex-data/vortex'
127+
with:
128+
sccache: s3
120129
- uses: actions/checkout@v6
121130
with:
122131
fetch-depth: 0
123-
- uses: ./.github/actions/prepare-java-linux
124132
- uses: actions/setup-java@v5
125133
with:
126134
distribution: "corretto"
127135
java-version: "17"
128-
- uses: ./.github/actions/setup-rust
136+
- uses: ./.github/actions/setup-prebuild
137+
- uses: mlugg/setup-zig@v2.2.1
138+
- name: Install cargo-zigbuild
139+
uses: taiki-e/cache-cargo-install-action@66c9585ef5ca780ee69399975a5e911f47905995
129140
with:
130-
targets: ${{ matrix.target.target }}
131-
repo-token: ${{ secrets.GITHUB_TOKEN }}
132-
enable-sccache: "false"
133-
- run: cargo build --release --package vortex-jni
141+
tool: cargo-zigbuild
142+
- run: cargo zigbuild --release --target ${{ matrix.target }}.2.31 --package vortex-jni
134143
- uses: actions/upload-artifact@v7
135144
with:
136-
name: "libvortex_jni_${{ matrix.target.target }}.zip"
137-
path: "target/release/libvortex_jni.so"
145+
name: "libvortex_jni_${{ matrix.target }}.zip"
146+
path: "target/${{ matrix.target }}/release/libvortex_jni.so"
138147
retention-days: 7
139148
if-no-files-found: error
140149

.github/workflows/publish-dry-runs.yml

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -64,31 +64,40 @@ jobs:
6464
working-directory: vortex-python/
6565

6666
check-java-publish-build:
67-
runs-on: ${{ matrix.target.runs-on }}
68-
container:
69-
image: "ubuntu:20.04"
7067
timeout-minutes: 30
7168
strategy:
7269
fail-fast: false
7370
matrix:
74-
target:
75-
- { os: ubuntu, runs-on: "ubuntu-24.04-arm", target: aarch64-unknown-linux-gnu }
76-
- { os: ubuntu, runs-on: "ubuntu-24.04", target: x86_64-unknown-linux-gnu }
71+
include:
72+
- target: x86_64-unknown-linux-gnu
73+
runner: runs-on=${{ github.run_id }}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=check-java-publish-build-amd64
74+
fallback_runner: ubuntu-24.04
75+
- target: aarch64-unknown-linux-gnu
76+
runner: runs-on=${{ github.run_id }}/runner=arm64-medium/image=ubuntu24-full-arm64-pre-v2/tag=check-java-publish-build-arm64
77+
fallback_runner: ubuntu-24.04-arm
78+
runs-on: >-
79+
${{ github.repository == 'vortex-data/vortex'
80+
&& matrix.runner
81+
|| matrix.fallback_runner }}
7782
steps:
83+
- uses: runs-on/action@v2
84+
if: github.repository == 'vortex-data/vortex'
85+
with:
86+
sccache: s3
7887
- uses: actions/checkout@v6
7988
with:
8089
fetch-depth: 0
81-
- uses: ./.github/actions/prepare-java-linux
8290
- uses: actions/setup-java@v5
8391
with:
8492
distribution: "corretto"
8593
java-version: "17"
86-
- uses: ./.github/actions/setup-rust
94+
- uses: ./.github/actions/setup-prebuild
95+
- uses: mlugg/setup-zig@v2.2.1
96+
- name: Install cargo-zigbuild
97+
uses: taiki-e/cache-cargo-install-action@66c9585ef5ca780ee69399975a5e911f47905995
8798
with:
88-
targets: ${{ matrix.target.target }}
89-
repo-token: ${{ secrets.GITHUB_TOKEN }}
90-
enable-sccache: "false"
91-
- run: cargo build --profile ci --package vortex-jni
99+
tool: cargo-zigbuild
100+
- run: cargo zigbuild --profile ci --target ${{ matrix.target }}.2.31 --package vortex-jni
92101

93102
compat-check:
94103
name: "Compat check"

0 commit comments

Comments
 (0)