Skip to content

Commit 5330d32

Browse files
add unstable encodings and patches to benchmarks (#7426)
1 parent 3e6834e commit 5330d32

10 files changed

Lines changed: 20 additions & 3 deletions

File tree

.github/scripts/run-sql-bench.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222

2323
set -Eeu -o pipefail
2424

25+
export VORTEX_EXPERIMENTAL_PATCHED_ARRAY=1
26+
export FLAT_LAYOUT_INLINE_ARRAY_NODE=1
27+
2528
subcommand="$1"
2629
targets="$2"
2730
shift 2

.github/workflows/bench-pr.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
env:
6161
RUSTFLAGS: "-C target-cpu=native"
6262
run: |
63-
cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}
63+
cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
6464
6565
- name: Setup Polar Signals
6666
if: github.event.pull_request.head.repo.fork == false
@@ -76,6 +76,8 @@ jobs:
7676
shell: bash
7777
env:
7878
RUST_BACKTRACE: full
79+
VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
80+
FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
7981
run: |
8082
bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json
8183

.github/workflows/bench.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
env:
7575
RUSTFLAGS: "-C target-cpu=native"
7676
run: |
77-
cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}
77+
cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
7878
7979
- name: Setup Polar Signals
8080
uses: polarsignals/gh-actions-ps-profiling@v0.8.1
@@ -89,6 +89,8 @@ jobs:
8989
shell: bash
9090
env:
9191
RUST_BACKTRACE: full
92+
VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
93+
FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
9294
run: |
9395
bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json
9496

.github/workflows/sql-benchmarks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ jobs:
144144
if [ "${{ matrix.build_lance }}" = "true" ]; then
145145
packages="$packages --bin lance-bench"
146146
fi
147-
cargo build $packages --profile release_debug
147+
cargo build $packages --profile release_debug --features unstable_encodings
148148
149149
- name: Generate data
150150
shell: bash

benchmarks/compress-bench/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ vortex-bench = { workspace = true }
3434

3535
[features]
3636
lance = ["dep:lance-bench"]
37+
unstable_encodings = ["vortex/unstable_encodings"]
3738

3839
[lints]
3940
workspace = true

benchmarks/datafusion-bench/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ custom-labels = { workspace = true }
4646

4747
[features]
4848
cuda = ["dep:vortex-cuda"]
49+
unstable_encodings = ["vortex/unstable_encodings"]
4950

5051
[lints]
5152
workspace = true

benchmarks/duckdb-bench/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ vortex-duckdb = { workspace = true }
2727

2828
[features]
2929
cuda = ["dep:vortex-cuda"]
30+
unstable_encodings = ["vortex/unstable_encodings"]
3031

3132
[lints]
3233
workspace = true

benchmarks/lance-bench/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,8 @@ tokio = { workspace = true, features = ["full"] }
2929
tracing = { workspace = true }
3030
vortex-bench = { workspace = true }
3131

32+
[features]
33+
unstable_encodings = ["vortex-bench/unstable_encodings"]
34+
3235
[lints]
3336
workspace = true

benchmarks/random-access-bench/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ vortex-bench = { workspace = true }
2626

2727
[features]
2828
lance = ["dep:lance-bench"]
29+
unstable_encodings = ["vortex-bench/unstable_encodings"]
2930

3031
[lints]
3132
workspace = true

vortex-bench/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,6 @@ vortex = { workspace = true, features = [
6363
"tokio",
6464
"zstd",
6565
] }
66+
67+
[features]
68+
unstable_encodings = ["vortex/unstable_encodings"]

0 commit comments

Comments
 (0)