Remove patches from BitPackedArray

removes both the patches field as well as all code for handling patches.
this is safe to do now that we have updated the VTable build function to
always read methods.

note that we need to leave the metadata as-is.

Signed-off-by: Andrew Duffy <andrew@a10y.dev>

Author: a10y

encodings/alp/src/alp_rd/mod.rs

@@ -8,6 +8,7 @@ use vortex_array::ExecutionCtx;
 use vortex_array::IntoArray;
 use vortex_array::patches::Patches;
 use vortex_array::validity::Validity;
+use vortex_fastlanes::bitpack_compress::BitPackedEncoder;
 use vortex_fastlanes::bitpack_compress::bitpack_encode_unchecked;
 
 mod array;
@@ -229,20 +230,19 @@ impl RDEncoder {
 
         // Bit-pack down the encoded left-parts array that have been dictionary encoded.
         let primitive_left = PrimitiveArray::new(left_parts, array.validity());
-        // SAFETY: by construction, all values in left_parts can be packed to left_bit_width.
-        let packed_left = unsafe {
-            bitpack_encode_unchecked(primitive_left, left_bit_width as _)
-                .vortex_expect("bitpack_encode_unchecked should succeed for left parts")
-                .into_array()
-        };
-
+        let packed_left = BitPackedEncoder::new(&primitive_left)
+            .with_bit_width(left_bit_width as _)
+            .pack()
+            .vortex_expect("bitpack_encode_unchecked should succeed for left parts")
+            .into_array()
+            .vortex_expect("Packed::into_array");
         let primitive_right = PrimitiveArray::new(right_parts, Validity::NonNullable);
-        // SAFETY: by construction, all values in right_parts are right_bit_width + leading zeros.
-        let packed_right = unsafe {
-            bitpack_encode_unchecked(primitive_right, self.right_bit_width as _)
-                .vortex_expect("bitpack_encode_unchecked should succeed for right parts")
-                .into_array()
-        };
+        let packed_right = BitPackedEncoder::new(&primitive_right)
+            .with_bit_width(self.right_bit_width as _)
+            .pack()
+            .vortex_expect("bitpack_encode_unchecked should succeed for right parts")
+            .into_array()
+            .vortex_expect("Packed::into_array");
 
         // Bit-pack the dict-encoded left-parts
         // Bit-pack the right-parts

encodings/fastlanes/benches/bitpacking_take.rs

@@ -161,12 +161,6 @@ fn patched_take_10_stratified(bencher: Bencher) {
     let uncompressed = PrimitiveArray::new(values, Validity::NonNullable);
     let packed = bitpack_to_best_bit_width(&uncompressed).unwrap();
 
-    assert!(packed.patches().is_some());
-    assert_eq!(
-        packed.patches().unwrap().num_patches(),
-        NUM_EXCEPTIONS as usize
-    );
-
     let indices = PrimitiveArray::from_iter((0..10).map(|i| i * 6_653));
 
     bencher
@@ -186,12 +180,6 @@ fn patched_take_10_contiguous(bencher: Bencher) {
     let uncompressed = PrimitiveArray::new(values, Validity::NonNullable);
     let packed = bitpack_to_best_bit_width(&uncompressed).unwrap();
 
-    assert!(packed.patches().is_some());
-    assert_eq!(
-        packed.patches().unwrap().num_patches(),
-        NUM_EXCEPTIONS as usize
-    );
-
     let indices = buffer![0..10].into_array();
 
     bencher
@@ -250,12 +238,6 @@ fn patched_take_10k_contiguous_patches(bencher: Bencher) {
     let uncompressed = PrimitiveArray::new(values, Validity::NonNullable);
     let packed = bitpack_to_best_bit_width(&uncompressed).unwrap();
 
-    assert!(packed.patches().is_some());
-    assert_eq!(
-        packed.patches().unwrap().num_patches(),
-        NUM_EXCEPTIONS as usize
-    );
-
     let indices =
         PrimitiveArray::from_iter((BIG_BASE2..BIG_BASE2 + NUM_EXCEPTIONS).cycle().take(10000));