cleanup

Signed-off-by: Andrew Duffy <andrew@a10y.dev>

Author: a10y

vortex-array/src/arrays/patched/array.rs

@@ -86,15 +86,15 @@ impl PatchedArray {
             values,
         } = transpose_patches(patches, ctx)?;
 
-        let len = inner.len();
-
         let values = PrimitiveArray::from_buffer_handle(
             BufferHandle::new_host(values),
             values_ptype,
             Validity::NonNullable,
         )
         .into_array();
 
+        let len = inner.len();
+
         Ok(Self {
             inner,
             n_chunks,

vortex-array/src/arrays/patched/mod.rs

@@ -32,25 +32,18 @@ const fn patch_lanes<V: Sized>() -> usize {
     if size_of::<V>() < 8 { 32 } else { 16 }
 }
 
+/// A cached accessor to the patch values.
 pub struct PatchAccessor<'a> {
     n_lanes: usize,
     lane_offsets: &'a [u32],
     indices: &'a [u16],
 }
 
-pub struct PatchOffset {
-    /// Global offset into the list of patches. These are some of the
-    pub index: usize,
-    /// This is the value stored in the `indices` buffer, which encodes the offset of the `index`-th
-    /// patch
-    pub chunk_offset: u16,
-}
-
 impl<'a> PatchAccessor<'a> {
     /// Get an iterator over indices and values offsets.
     ///
-    /// The first component is the index into the `indices` and `values`, and the second component
-    /// is the set of values instead here...I think?
+    /// The first component is the index into the `indices` and `values`, and the second is
+    /// the datum from `indices[index]` already prefetched.
     pub fn offsets_iter(
         &self,
         chunk: usize,
@@ -62,25 +55,3 @@ impl<'a> PatchAccessor<'a> {
         std::iter::zip(start..stop, self.indices[start..stop].iter().copied())
     }
 }
-
-pub struct LanePatches<'a, V> {
-    pub indices: &'a [u16],
-    pub values: &'a [V],
-}
-
-impl<'a, V: Copy> LanePatches<'a, V> {
-    pub fn len(&self) -> usize {
-        self.indices.len()
-    }
-
-    pub fn is_empty(&self) -> bool {
-        self.indices.is_empty()
-    }
-
-    pub fn iter(&self) -> impl Iterator<Item = (u16, V)> {
-        self.indices
-            .iter()
-            .copied()
-            .zip(self.values.iter().copied())
-    }
-}