Commit 60c1227
authored
Assortment of
## Rationale for this change
General improvements of the `FileSource`-based Apache DataFusion
integration.
## What changes are included in this PR?
1. DF metrics are in use, so make better use of them both on reads and
writes, which is a step towards having the same default observability
that `ParquetSource` provides.
2. Fix a subtle issue where a dynamic expression only references
partition literals, which we currently don't handle correctly.
3. Drop `batch_size` from the source, by default DataFusion splits the
data coming out of `DataScanExec` nodes.
4. Make sure we keep schema and field metadata through all the
projections paths.
## What APIs are changed? Are there any user-facing changes?
More metrics will be reported in DF, and batch size needs to be done
through the `DataSourceExec` and `FileScanConfig` level.
---------
Signed-off-by: Adam Gutglick <adam@spiraldb.com>VortexSource improvements and fixes (#8718)1 parent c981534 commit 60c1227
4 files changed
Lines changed: 363 additions & 78 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
60 | 63 | | |
61 | 64 | | |
62 | 65 | | |
| |||
246 | 249 | | |
247 | 250 | | |
248 | 251 | | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
249 | 278 | | |
250 | 279 | | |
251 | 280 | | |
| |||
0 commit comments