Skip to content

Commit 651151d

Browse files
committed
Use unqualified vortex_err macro in PiecewiseSequential
Signed-off-by: Daniel King <dan@spiraldb.com>
1 parent 325c23a commit 651151d

2 files changed

Lines changed: 13 additions & 16 deletions

File tree

vortex-array/src/arrays/piecewise_sequential/mod.rs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use vortex_buffer::BufferMut;
1212
use vortex_error::VortexResult;
1313
use vortex_error::vortex_bail;
1414
use vortex_error::vortex_ensure;
15+
use vortex_error::vortex_err;
1516

1617
use crate::ArrayRef;
1718
use crate::array::ArrayView;
@@ -69,7 +70,7 @@ fn check_index_array(name: &str, array: &ArrayRef) -> VortexResult<()> {
6970
pub(crate) fn checked_range_end(start: usize, length: usize) -> VortexResult<usize> {
7071
start
7172
.checked_add(length)
72-
.ok_or_else(|| vortex_error::vortex_err!("PiecewiseSequentialArray range overflows usize"))
73+
.ok_or_else(|| vortex_err!("PiecewiseSequentialArray range overflows usize"))
7374
}
7475

7576
pub(crate) fn materialize_ranges<S, L>(
@@ -90,9 +91,9 @@ where
9091
let start: usize = start.as_();
9192
let length: usize = length.as_();
9293
let end = checked_range_end(start, length)?;
93-
computed_len = computed_len.checked_add(length).ok_or_else(|| {
94-
vortex_error::vortex_err!("PiecewiseSequentialArray output length overflows usize")
95-
})?;
94+
computed_len = computed_len
95+
.checked_add(length)
96+
.ok_or_else(|| vortex_err!("PiecewiseSequentialArray output length overflows usize"))?;
9697

9798
values.extend((start..end).map(|value| value as u64));
9899
}
@@ -119,16 +120,16 @@ where
119120
for (&start, &length) in starts.iter().zip_eq(lengths) {
120121
let start: usize = start.as_();
121122
let length: usize = length.as_();
122-
let end = start.checked_add(length).ok_or_else(|| {
123-
vortex_error::vortex_err!("PiecewiseSequentialArray range overflows usize")
124-
})?;
123+
let end = start
124+
.checked_add(length)
125+
.ok_or_else(|| vortex_err!("PiecewiseSequentialArray range overflows usize"))?;
125126
vortex_ensure!(
126127
end <= source_len,
127128
"PiecewiseSequentialArray range {start}..{end} exceeds source length {source_len}"
128129
);
129-
computed_len = computed_len.checked_add(length).ok_or_else(|| {
130-
vortex_error::vortex_err!("PiecewiseSequentialArray output length overflows usize")
131-
})?;
130+
computed_len = computed_len
131+
.checked_add(length)
132+
.ok_or_else(|| vortex_err!("PiecewiseSequentialArray output length overflows usize"))?;
132133
}
133134

134135
vortex_ensure!(

vortex-array/src/arrays/piecewise_sequential/vtable.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,10 @@ impl VTable for PiecewiseSequential {
8585
);
8686
let starts = slots[PiecewiseSequentialSlots::STARTS]
8787
.as_ref()
88-
.ok_or_else(|| {
89-
vortex_error::vortex_err!("PiecewiseSequentialArray starts slot must be present")
90-
})?;
88+
.ok_or_else(|| vortex_err!("PiecewiseSequentialArray starts slot must be present"))?;
9189
let lengths = slots[PiecewiseSequentialSlots::LENGTHS]
9290
.as_ref()
93-
.ok_or_else(|| {
94-
vortex_error::vortex_err!("PiecewiseSequentialArray lengths slot must be present")
95-
})?;
91+
.ok_or_else(|| vortex_err!("PiecewiseSequentialArray lengths slot must be present"))?;
9692
check_index_arrays(starts, lengths)
9793
}
9894

0 commit comments

Comments
 (0)