address comments

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Author: connortsui20

encodings/fastlanes/src/bitpacking/plugin.rs

@@ -128,7 +128,7 @@ mod tests {
 
         let array = bitpacked.as_array();
 
-        let metadata = SESSION.array_serialize(array)?.unwrap_or_default();
+        let metadata = SESSION.array_serialize(array)?.unwrap();
         let children = array.children();
         let buffers = array
             .buffers()
@@ -177,7 +177,7 @@ mod tests {
 
         let array = bitpacked.as_array();
 
-        let metadata = SESSION.array_serialize(array)?.unwrap_or_default();
+        let metadata = SESSION.array_serialize(array)?.unwrap();
         let children = array.children();
         let buffers = array
             .buffers()
@@ -207,7 +207,7 @@ mod tests {
     fn primitive_array_returns_error() -> VortexResult<()> {
         let array = PrimitiveArray::from_iter([1i32, 2, 3]).into_array();
 
-        let metadata = SESSION.array_serialize(&array)?.unwrap_or_default();
+        let metadata = SESSION.array_serialize(&array)?.unwrap();
         let children = array.children();
         let buffers = array
             .buffers()

encodings/parquet-variant/src/vtable.rs

@@ -246,7 +246,6 @@ mod tests {
     use vortex_array::IntoArray;
     use vortex_array::Precision;
     use vortex_array::arrays::VarBinViewArray;
-    use vortex_array::arrays::Variant;
     use vortex_array::arrays::VariantArray;
     use vortex_array::dtype::DType;
     use vortex_array::dtype::Nullability;
@@ -264,13 +263,13 @@ mod tests {
 
     use crate::ParquetVariant;
     use crate::array::ParquetVariantArrayExt;
+
     fn roundtrip(array: ArrayRef) -> ArrayRef {
         let dtype = array.dtype().clone();
         let len = array.len();
 
         let session = VortexSession::empty().with::<ArraySession>();
         session.arrays().register(ParquetVariant);
-        session.arrays().register(Variant);
 
         let ctx = ArrayContext::empty();
         let serialized = array
@@ -282,8 +281,6 @@ mod tests {
             concat.extend_from_slice(buf.as_ref());
         }
         let concat = concat.freeze();
-        session.arrays().register(ParquetVariant);
-        session.arrays().register(Variant);
 
         let parts = SerializedArray::try_from(concat).unwrap();
         parts

encodings/zigzag/src/lib.rs

@@ -6,3 +6,12 @@ pub use vtable::*;
 
 mod compress;
 mod vtable;
+
+use vortex_array::arrays::scalar_fn::plugin::ScalarFnArrayPlugin;
+use vortex_array::session::ArraySessionExt;
+use vortex_session::VortexSession;
+
+/// Initialize sequence encoding in the given session.
+pub fn initialize(session: &VortexSession) {
+    session.arrays().register(ScalarFnArrayPlugin::new(ZigZag));
+}

vortex-array/src/session/mod.rs

@@ -4,6 +4,7 @@
 use std::sync::Arc;
 
 use vortex_error::VortexResult;
+use vortex_error::vortex_bail;
 use vortex_session::Ref;
 use vortex_session::SessionExt;
 use vortex_session::registry::Registry;
@@ -96,8 +97,9 @@ pub trait ArraySessionExt: SessionExt {
     /// Serialize an array using a plugin from the registry.
     fn array_serialize(&self, array: &ArrayRef) -> VortexResult<Option<Vec<u8>>> {
         let Some(plugin) = self.arrays().registry.find(&array.encoding_id()) else {
-            return Ok(None);
+            vortex_bail!("Array is not registered for serializations");
         };
+
         plugin.serialize(array, &self.session())
     }
 }

vortex-file/src/lib.rs

@@ -110,14 +110,12 @@ pub use forever_constant::*;
 pub use open::*;
 pub use strategy::*;
 use vortex_array::arrays::Dict;
-use vortex_array::arrays::scalar_fn::plugin::ScalarFnArrayPlugin;
 use vortex_array::session::ArraySessionExt;
 use vortex_bytebool::ByteBool;
 use vortex_fsst::FSST;
 use vortex_pco::Pco;
 use vortex_session::VortexSession;
 use vortex_sparse::Sparse;
-use vortex_zigzag::ZigZag;
 pub use writer::*;
 
 /// The current version of the Vortex file format
@@ -164,7 +162,7 @@ pub fn register_default_encodings(session: &VortexSession) {
         arrays.register(FSST);
         arrays.register(Pco);
         arrays.register(Sparse);
-        arrays.register(ScalarFnArrayPlugin::new(ZigZag));
+
         #[cfg(feature = "zstd")]
         arrays.register(vortex_zstd::Zstd);
         #[cfg(all(feature = "zstd", feature = "unstable_encodings"))]
@@ -179,6 +177,7 @@ pub fn register_default_encodings(session: &VortexSession) {
     vortex_fastlanes::initialize(session);
     vortex_runend::initialize(session);
     vortex_sequence::initialize(session);
+    vortex_zigzag::initialize(session);
 
     #[cfg(feature = "unstable_encodings")]
     vortex_tensor::initialize(session);