Skip to content

Commit 770a6f2

Browse files
committed
fixup
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
1 parent 38c0379 commit 770a6f2

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/sql-benchmarks.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ on:
7676
"subcommand": "fineweb",
7777
"name": "FineWeb NVMe",
7878
"targets": "datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact",
79-
"scale_factor": "100"
79+
"iterations": "10"
8080
},
8181
{
8282
"id": "fineweb-s3",
@@ -85,7 +85,6 @@ on:
8585
"local_dir": "vortex-bench/data/fineweb",
8686
"remote_storage": "s3://vortex-ci-benchmark-datasets/${{github.ref_name}}/${{github.run_id}}/fineweb/",
8787
"targets": "datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact",
88-
"scale_factor": "100",
8988
"iterations": "10"
9089
},
9190
{
@@ -140,11 +139,17 @@ jobs:
140139
shell: bash
141140
run: |
142141
targets="${{ matrix.targets }}"
143-
# Non-PR modes include lance comparisons for clickbench and tpch
142+
# Non-PR modes include additional targets
144143
if [ "${{ inputs.mode }}" != "pr" ]; then
145144
case "${{ matrix.subcommand }}" in
146-
clickbench|tpch) targets="$targets,datafusion:lance" ;;
145+
clickbench) targets="$targets,datafusion:vortex-compact,duckdb:vortex-compact" ;;
147146
esac
147+
# Lance comparisons for local clickbench/tpch (not S3)
148+
if [ -z "${{ matrix.remote_storage }}" ]; then
149+
case "${{ matrix.subcommand }}" in
150+
clickbench|tpch) targets="$targets,datafusion:lance" ;;
151+
esac
152+
fi
148153
fi
149154
echo "targets=$targets" >> $GITHUB_OUTPUT
150155

0 commit comments

Comments
 (0)