Commit 797b650
fix(vortex-bench): map gs:// scheme to gcs storage label (#8630)
## Rationale for this change
Running the benchmark harness (`datafusion-bench` / `query_bench`)
against a remote
dataset on Google Cloud Storage (`--opt remote-data-dir=gs://…`) fails
immediately
during benchmark setup with:
```
Error: unknown URL scheme: gs
```
`vortex-bench`'s `url_scheme_to_storage` helper — which maps a data-dir
URL scheme to a
`storage` label used for result reporting — only handled `s3` and
`file`, so any `gs://`
run bailed before a single query executed. S3 remote runs work because
`s3` is handled;
GCS was simply never covered. `make_object_store` already supports
`gs://` for the actual
reads, so the only gap was this reporting helper.
## What changes are included in this PR?
- Add a `STORAGE_GCS = "gcs"` constant.
- Add a `"gs"` arm to `url_scheme_to_storage` returning that label.
Verified by running TPC-H SF1 from a GCS bucket end-to-end (DataFusion +
Vortex, 22/22
queries executing against `gs://…`, results tagged `storage=gcs`).
## What APIs are changed? Are there any user-facing changes?
None. This only affects the benchmark harness's storage-label reporting;
no public API,
format, or behavior change outside `vortex-bench`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 5d3be01 commit 797b650
2 files changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
| 164 | + | |
164 | 165 | | |
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
| 170 | + | |
169 | 171 | | |
170 | 172 | | |
171 | 173 | | |
| |||
0 commit comments