Skip to content

Commit 7a228aa

Browse files
authored
fix: speed up coverage tests and install LLVM tools path (#8136)
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
1 parent bbc2c72 commit 7a228aa

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/rust-instrumented.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ jobs:
5353
cargo nextest run --locked --workspace --all-features --no-fail-fast
5454
- name: Generate coverage report
5555
run: |
56+
set -euo pipefail
57+
LLVM_TOOLS_BIN="$(dirname "$(rustup which llvm-profdata)")"
5658
grcov . --binary-path target/debug/ -s . -t lcov --llvm --ignore-not-existing \
59+
--llvm-path "${LLVM_TOOLS_BIN}" \
5760
--threads $(nproc) \
5861
--ignore '../*' --ignore '/*' --ignore 'fuzz/*' --ignore 'vortex-bench/*' \
5962
--ignore 'home/*' --ignore 'xtask/*' --ignore 'target/*' --ignore 'vortex-error/*' \
@@ -62,6 +65,7 @@ jobs:
6265
--ignore 'vortex-ffi/examples/*' --ignore '*/arbitrary/*' --ignore '*/arbitrary.rs' --ignore 'vortex-cxx/*' \
6366
--ignore benchmarks/* --ignore 'vortex-test/*' \
6467
-o ${{ env.GRCOV_OUTPUT_FILE }}
68+
test -s ${{ env.GRCOV_OUTPUT_FILE }}
6569
- name: Codecov
6670
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
6771
with:

benchmarks-website/server/tests/landing.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,11 +416,11 @@ async fn landing_page_honours_filter_query_params() -> Result<()> {
416416
/// full history via the explicit `/api/chart/{slug}?n=all` refetch.
417417
#[tokio::test]
418418
async fn landing_first_group_shard_caps_commits() -> Result<()> {
419-
// 250 commits is comfortably above the 100-commit artifact cap so the
419+
// 101 commits is the smallest fixture above the 100-commit artifact cap, so the
420420
// cap actually kicks in. `seed_long_history` only seeds the Random-Access
421421
// group; with the canonical group ordering Random Access sorts first.
422422
let server = Server::start().await?;
423-
seed_long_history(&server, 250).await?;
423+
seed_long_history(&server, 101).await?;
424424

425425
let client = reqwest::Client::new();
426426
let body = client.get(server.url("/")).send().await?.text().await?;
@@ -454,7 +454,7 @@ async fn landing_first_group_shard_caps_commits() -> Result<()> {
454454
assert_eq!(
455455
commits.len(),
456456
100,
457-
"with 250 seeded commits the shard payload should be exactly the \
457+
"with 101 seeded commits the shard payload should be exactly the \
458458
100-commit cap; got {}",
459459
commits.len(),
460460
);

benchmarks-website/server/tests/permalinks.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use self::common::seed_long_history;
2525
#[tokio::test]
2626
async fn permalink_pages_default_to_latest_100_and_opt_into_full_history() -> Result<()> {
2727
let server = Server::start().await?;
28-
seed_long_history(&server, 200).await?;
28+
seed_long_history(&server, 101).await?;
2929

3030
let chart_slug = pick_chart_slug(&server, |s| s == "Random Access").await?;
3131
let group_slug = pick_group_slug(&server, |s| s == "Random Access").await?;
@@ -61,7 +61,7 @@ async fn permalink_pages_default_to_latest_100_and_opt_into_full_history() -> Re
6161
.as_array()
6262
.context("all commits is array")?
6363
.len(),
64-
200,
64+
101,
6565
"/chart?n=all should inline the full raw history",
6666
);
6767

0 commit comments

Comments
 (0)