Skip to content

Commit 7f69190

Browse files
committed
make list layout the default
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
1 parent 8ba1a80 commit 7f69190

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

vortex-file/src/strategy.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ use vortex_layout::layouts::compressed::CompressingStrategy;
5050
use vortex_layout::layouts::compressed::CompressorPlugin;
5151
use vortex_layout::layouts::dict::writer::DictStrategy;
5252
use vortex_layout::layouts::flat::writer::FlatLayoutStrategy;
53-
#[cfg(feature = "unstable_encodings")]
5453
use vortex_layout::layouts::list::writer::ListLayoutStrategy;
5554
use vortex_layout::layouts::repartition::RepartitionStrategy;
5655
use vortex_layout::layouts::repartition::RepartitionWriterOptions;
@@ -244,11 +243,9 @@ impl WriteStrategyBuilder {
244243
Arc::new(FlatLayoutStrategy::default())
245244
};
246245

247-
// 7. for each chunk create a layout. Under the `unstable_encodings` feature, list-typed
248-
// chunks route through `ListLayoutStrategy` (separately-addressable elements/offsets/
249-
// validity sub-layouts; non-list chunks fall through its built-in fallback to `flat`).
250-
// Otherwise everything goes through the flat strategy.
251-
#[cfg(feature = "unstable_encodings")]
246+
// 7. for each chunk create a layout. List-typed chunks route through
247+
// `ListLayoutStrategy` (separately-addressable elements/offsets/validity sub-layouts;
248+
// non-list chunks fall through its built-in fallback to `flat`).
252249
let leaf: Arc<dyn LayoutStrategy> = Arc::new(
253250
// Thread the configured `flat` (which carries `allow_encodings` / any custom flat
254251
// override) through every child.
@@ -258,8 +255,6 @@ impl WriteStrategyBuilder {
258255
.with_validity(Arc::clone(&flat))
259256
.with_fallback(Arc::clone(&flat)),
260257
);
261-
#[cfg(not(feature = "unstable_encodings"))]
262-
let leaf: Arc<dyn LayoutStrategy> = Arc::clone(&flat);
263258

264259
let chunked = ChunkedLayoutStrategy::new(leaf);
265260
// 6. buffer chunks so they end up with closer segment ids physically

0 commit comments

Comments
 (0)