Skip to content

Commit 8daa260

Browse files
committed
suppress some unit tests from miri
due to upstream parking_lot issue Signed-off-by: Andrew Duffy <andrew@a10y.dev>
1 parent 6f6e6f9 commit 8daa260

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

vortex-ffi/src/array.rs

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ mod tests {
208208
use crate::string::vx_string_free;
209209

210210
#[test]
211+
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
212+
#[cfg_attr(miri, ignore)]
211213
fn test_simple() {
212214
unsafe {
213215
let primitive = PrimitiveArray::new(buffer![1i32, 2i32, 3i32], Validity::NonNullable);
@@ -230,6 +232,8 @@ mod tests {
230232
}
231233

232234
#[test]
235+
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
236+
#[cfg_attr(miri, ignore)]
233237
fn test_slice() {
234238
unsafe {
235239
let primitive =
@@ -250,8 +254,8 @@ mod tests {
250254
}
251255

252256
#[test]
253-
#[cfg_attr(miri, ignore)]
254257
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
258+
#[cfg_attr(miri, ignore)]
255259
fn test_null_operations() {
256260
unsafe {
257261
let primitive = PrimitiveArray::new(
@@ -277,8 +281,8 @@ mod tests {
277281
}
278282

279283
#[test]
280-
#[cfg_attr(miri, ignore)]
281284
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
285+
#[cfg_attr(miri, ignore)]
282286
fn test_get_field() {
283287
unsafe {
284288
let names = VarBinViewArray::from_iter_str(["Alice", "Bob", "Charlie"]);
@@ -317,6 +321,8 @@ mod tests {
317321
}
318322

319323
#[test]
324+
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
325+
#[cfg_attr(miri, ignore)]
320326
fn test_primitive_getters() {
321327
unsafe {
322328
// Test a representative sample of primitive types
@@ -367,6 +373,8 @@ mod tests {
367373
}
368374

369375
#[test]
376+
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
377+
#[cfg_attr(miri, ignore)]
370378
fn test_get_utf8() {
371379
unsafe {
372380
let utf8_array = VarBinViewArray::from_iter_str(["hello", "world", "test"]);
@@ -389,6 +397,8 @@ mod tests {
389397
}
390398

391399
#[test]
400+
// TODO(joe): enable once this is fixed https://github.com/Amanieu/parking_lot/issues/477
401+
#[cfg_attr(miri, ignore)]
392402
fn test_get_binary() {
393403
unsafe {
394404
let binary_array = VarBinViewArray::from_iter_bin(vec![

0 commit comments

Comments
 (0)