deprecate all decompression methods without a context

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/benches/take_patches.rs

@@ -11,6 +11,7 @@ use rand::rngs::StdRng;
 use vortex_array::ArrayRef;
 use vortex_array::IntoArray;
 use vortex_array::LEGACY_SESSION;
+#[allow(deprecated)]
 use vortex_array::ToCanonical;
 use vortex_array::VortexSessionExecute;
 use vortex_array::patches::Patches;
@@ -37,6 +38,7 @@ const BENCH_ARGS: &[(f64, f64)] = &[
 ];
 
 #[divan::bench(args = BENCH_ARGS)]
+#[expect(deprecated)]
 fn take_search(bencher: Bencher, (patches_sparsity, index_multiple): (f64, f64)) {
     let mut rng = StdRng::seed_from_u64(0);
     let patches = fixture(65536, patches_sparsity, &mut rng);
@@ -54,6 +56,7 @@ fn take_search(bencher: Bencher, (patches_sparsity, index_multiple): (f64, f64))
 }
 
 #[divan::bench(args = BENCH_ARGS)]
+#[expect(deprecated)]
 fn take_search_chunked(bencher: Bencher, (patches_sparsity, index_multiple): (f64, f64)) {
     let mut rng = StdRng::seed_from_u64(0);
     let patches = fixture_with_chunk_offsets(65536, patches_sparsity, &mut rng);
@@ -71,6 +74,7 @@ fn take_search_chunked(bencher: Bencher, (patches_sparsity, index_multiple): (f6
 }
 
 #[divan::bench(args = BENCH_ARGS)]
+#[expect(deprecated)]
 fn take_map(bencher: Bencher, (patches_sparsity, index_multiple): (f64, f64)) {
     let mut rng = StdRng::seed_from_u64(0);
     let patches = fixture(65536, patches_sparsity, &mut rng);

vortex-array/benches/varbinview_compact.rs

@@ -7,6 +7,7 @@ use rand::SeedableRng;
 use rand::rngs::StdRng;
 use vortex_array::ArrayRef;
 use vortex_array::IntoArray;
+#[allow(deprecated)]
 use vortex_array::ToCanonical;
 use vortex_array::arrays::VarBinViewArray;
 use vortex_array::builders::VarBinViewBuilder;
@@ -37,6 +38,7 @@ fn compact_sliced(bencher: Bencher, args: (usize, usize)) {
     compact_sliced_impl(bencher, args);
 }
 
+#[expect(deprecated)]
 fn compact_impl(bencher: Bencher, (output_size, utilization_pct): (usize, usize)) {
     let base_size = (output_size * 100) / utilization_pct;
     let base_array = build_varbinview_fixture(base_size);
@@ -54,6 +56,7 @@ fn compact_impl(bencher: Bencher, (output_size, utilization_pct): (usize, usize)
     })
 }
 
+#[expect(deprecated)]
 fn compact_sliced_impl(bencher: Bencher, (output_size, utilization_pct): (usize, usize)) {
     let base_size = (output_size * 100) / utilization_pct;
     let base_array = build_varbinview_fixture(base_size);

vortex-array/src/array/erased.rs

@@ -301,11 +301,14 @@ impl ArrayRef {
     }
 
     /// Returns the canonical representation of the array.
+    #[deprecated(note = "use `array.execute::<Canonical>(ctx)` instead")]
     pub fn into_canonical(self) -> VortexResult<Canonical> {
         self.execute(&mut LEGACY_SESSION.create_execution_ctx())
     }
 
     /// Returns the canonical representation of the array.
+    #[deprecated(note = "use `array.execute::<Canonical>(ctx)` instead")]
+    #[expect(deprecated)]
     pub fn to_canonical(&self) -> VortexResult<Canonical> {
         self.clone().into_canonical()
     }

vortex-array/src/array/typed.rs

@@ -394,6 +394,7 @@ impl<V: VTable> Array<V> {
     }
 
     #[deprecated(note = "Use Array::<V>::execute::<Canonical>() instead")]
+    #[expect(deprecated)]
     pub fn to_canonical(&self) -> VortexResult<crate::Canonical> {
         self.inner.to_canonical()
     }

vortex-array/src/arrays/arbitrary.rs

@@ -13,6 +13,7 @@ use vortex_error::VortexExpect;
 
 use crate::ArrayRef;
 use crate::IntoArray;
+#[allow(deprecated)]
 use crate::ToCanonical;
 use crate::arrays::BoolArray;
 use crate::arrays::ChunkedArray;
@@ -83,6 +84,7 @@ fn random_array(u: &mut Unstructured, dtype: &DType, len: Option<usize>) -> Resu
 }
 
 /// Creates a random array chunk.
+#[expect(deprecated)]
 fn random_array_chunk(
     u: &mut Unstructured<'_>,
     dtype: &DType,

vortex-array/src/arrays/bool/compute/fill_null.rs

@@ -42,6 +42,7 @@ impl FillNullKernel for Bool {
 }
 
 #[cfg(test)]
+#[allow(deprecated)]
 mod tests {
     use rstest::rstest;
     use vortex_buffer::BitBuffer;

vortex-array/src/arrays/bool/compute/take.rs

@@ -84,6 +84,7 @@ mod test {
     use vortex_buffer::buffer;
 
     use crate::IntoArray as _;
+    #[allow(deprecated)]
     use crate::ToCanonical;
     use crate::arrays::BoolArray;
     use crate::arrays::PrimitiveArray;
@@ -93,6 +94,7 @@ mod test {
     use crate::validity::Validity;
 
     #[test]
+    #[expect(deprecated)]
     fn take_nullable() {
         let reference = BoolArray::from_iter(vec![
             Some(false),

vortex-array/src/arrays/bool/vtable/operations.rs

@@ -28,12 +28,14 @@ mod tests {
     use std::iter;
 
     use crate::IntoArray;
+    #[allow(deprecated)]
     use crate::ToCanonical;
     use crate::arrays::BoolArray;
     use crate::arrays::bool::BoolArrayExt;
     use crate::assert_arrays_eq;
 
     #[test]
+    #[expect(deprecated)]
     fn test_slice_hundred_elements() {
         let arr = BoolArray::from_iter(iter::repeat_n(Some(true), 100));
         let sliced_arr = arr.into_array().slice(8..16).unwrap().to_bool();
@@ -43,6 +45,7 @@ mod tests {
     }
 
     #[test]
+    #[expect(deprecated)]
     fn test_slice() {
         let arr = BoolArray::from_iter([Some(true), Some(true), None, Some(false), None]);
         let sliced_arr = arr.into_array().slice(1..4).unwrap().to_bool();

vortex-array/src/arrays/chunked/array.rs

@@ -179,6 +179,7 @@ impl Array<Chunked> {
         })
     }
 
+    #[expect(deprecated)]
     pub fn rechunk(&self, target_bytesize: u64, target_rowsize: usize) -> VortexResult<Self> {
         let mut new_chunks = Vec::new();
         let mut chunks_to_combine = Vec::new();

vortex-array/src/arrays/chunked/compute/take.rs

@@ -126,6 +126,7 @@ mod test {
     use vortex_error::VortexResult;
 
     use crate::IntoArray;
+    #[allow(deprecated)]
     use crate::ToCanonical;
     use crate::arrays::BoolArray;
     use crate::arrays::ChunkedArray;
@@ -254,6 +255,7 @@ mod test {
     }
 
     #[test]
+    #[expect(deprecated)]
     fn test_take_shuffled_large() -> VortexResult<()> {
         let nchunks: i32 = 100;
         let chunk_len: i32 = 1_000;