fix: remove Arc double-wrapping in vortex-ffi apply and tests

The `vx_array::new(Arc::new(x.into_array()))` pattern double-wraps
arrays since `into_array()` already returns `Arc<dyn DynArray>`.
With the new `apply(self: Arc<Self>)` signature, this breaks downcasting
because the concrete type behind the trait object becomes
`Arc<dyn DynArray>` instead of the actual encoding type.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-ffi/src/array.rs

@@ -414,7 +414,7 @@ pub unsafe extern "C" fn vx_array_apply(
         vortex_ensure!(!expression.is_null());
         let array = vx_array::as_ref(array);
         let expression = vx_expression::as_ref(expression);
-        Ok(vx_array::new(Arc::new(array.clone().apply(expression)?)))
+        Ok(vx_array::new(array.clone().apply(expression)?))
     })
 }
 

vortex-ffi/src/expression.rs

@@ -295,7 +295,6 @@ pub unsafe extern "C" fn vx_expression_list_contains(
 #[cfg(test)]
 mod tests {
     use std::ptr;
-    use std::sync::Arc;
 
     use vortex::array::IntoArray;
     use vortex::array::ToCanonical;
@@ -355,7 +354,7 @@ mod tests {
             let column = vx_expression_get_item(c"age".as_ptr(), root);
             assert_ne!(column, ptr::null_mut());
 
-            let array = vx_array::new(Arc::new(array.into_array()));
+            let array = vx_array::new(array.into_array());
             let mut error = ptr::null_mut();
 
             let applied_array = vx_array_apply(array, column, &raw mut error);
@@ -378,7 +377,7 @@ mod tests {
             assert!(!error.is_null());
             vx_error_free(error);
 
-            let names_array_vx = vx_array::new(Arc::new(names_array.into_array()));
+            let names_array_vx = vx_array::new(names_array.into_array());
             let applied_array = vx_array_apply(names_array_vx, column, &raw mut error);
             assert!(applied_array.is_null());
             assert!(!error.is_null());
@@ -399,7 +398,7 @@ mod tests {
         unsafe {
             let root = vx_expression_root();
 
-            let array = vx_array::new(Arc::new(array.into_array()));
+            let array = vx_array::new(array.into_array());
 
             let columns = [c"name".as_ptr(), c"age".as_ptr()];
             let column = vx_expression_select(columns.as_ptr(), 2, root);
@@ -441,7 +440,7 @@ mod tests {
         let array = StructArray::try_new(names, fields, 4, Validity::NonNullable);
 
         unsafe {
-            let array = vx_array::new(Arc::new(array.unwrap().into_array()));
+            let array = vx_array::new(array.unwrap().into_array());
 
             let root = vx_expression_root();
             let expression_col1 = vx_expression_get_item(c"col1".as_ptr(), root);
@@ -524,7 +523,7 @@ mod tests {
 
         unsafe {
             let root = vx_expression_root();
-            let array = vx_array::new(Arc::new(array.into_array()));
+            let array = vx_array::new(array.into_array());
             let expression_value = vx_expression::new(Box::new(lit(1)));
 
             let expression = vx_expression_list_contains(root, expression_value);