Some more docs

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Author: AdamGS

encodings/parquet-variant/src/vtable.rs

@@ -466,7 +466,9 @@ mod tests {
             None,
         )
         .unwrap();
-        let typed_value = VariantArray::new(inner_pv.into_array()).into_array();
+        let typed_value = VariantArray::try_new(inner_pv.into_array(), None)
+            .unwrap()
+            .into_array();
 
         let outer_pv = ParquetVariant::try_new(
             Validity::NonNullable,

vortex-array/public-api.lock

@@ -23004,8 +23004,6 @@ pub fn vortex_array::Array<vortex_array::arrays::VarBinView>::try_new(vortex_buf
 
 impl vortex_array::Array<vortex_array::arrays::Variant>
 
-pub fn vortex_array::Array<vortex_array::arrays::Variant>::new(vortex_array::ArrayRef) -> Self
-
 pub fn vortex_array::Array<vortex_array::arrays::Variant>::try_new(vortex_array::ArrayRef, core::option::Option<vortex_array::ArrayRef>) -> vortex_error::VortexResult<Self>
 
 impl vortex_array::Array<vortex_array::arrays::dict::Dict>

vortex-array/src/aggregate_fn/fns/uncompressed_size_in_bytes/mod.rs

@@ -548,7 +548,7 @@ mod tests {
     #[test]
     fn variant_stat_is_unsupported() -> VortexResult<()> {
         let child = ConstantArray::new(Scalar::variant(Scalar::from(42i32)), 3).into_array();
-        let array = VariantArray::new(child).into_array();
+        let array = VariantArray::try_new(child, None)?.into_array();
         let mut ctx = LEGACY_SESSION.create_execution_ctx();
 
         assert_eq!(

vortex-array/src/arrays/constant/vtable/canonical.rs

@@ -165,9 +165,10 @@ pub(crate) fn constant_canonicalize(
             })
         }
         DType::Union(..) => todo!("TODO(connor)[Union]: unimplemented"),
-        DType::Variant(_) => {
-            Canonical::Variant(VariantArray::new(array.array().clone().into_array()))
-        }
+        DType::Variant(_) => Canonical::Variant(VariantArray::try_new(
+            array.array().clone().into_array(),
+            None,
+        )?),
         DType::Extension(ext_dtype) => {
             let s = scalar.as_extension();
 

vortex-array/src/arrays/variant/mod.rs

@@ -51,6 +51,12 @@ impl<T: TypedArrayRef<Variant>> VariantArrayExt for T {}
 
 impl Array<Variant> {
     /// Creates a new `VariantArray` with logical variant core storage and optional shredded storage.
+    ///
+    /// `core_storage` must have `DType::Variant`, but it may use any Variant-typed physical
+    /// encoding. See [`VariantArrayExt`] for the higher-level storage contract.
+    ///
+    /// `shredded`, when present, must be row-aligned with `core_storage` and stores typed values for
+    /// selected variant paths.
     pub fn try_new(core_storage: ArrayRef, shredded: Option<ArrayRef>) -> VortexResult<Self> {
         let dtype = core_storage.dtype().clone();
         vortex_ensure!(
@@ -65,11 +71,6 @@ impl Array<Variant> {
         )?
         .with_stats_set(stats))
     }
-
-    /// Creates a new `VariantArray`.
-    pub fn new(core_storage: ArrayRef) -> Self {
-        Self::try_new(core_storage, None).vortex_expect("invalid VariantArray core_storage")
-    }
 }
 
 #[cfg(test)]