Merge branch 'develop' into ji/sub-segment-read

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

.github/AGENTS.md

@@ -5,7 +5,6 @@ Nightly is required for:
 - `-Z` flags: sanitizers (`-Zsanitizer=address`), miri (`-Zmiri-*`), publish (`-Zpublish-timeout`)
 - `cargo-fuzz` (requires nightly)
 - `public-api` xtask (nightly rustdoc JSON)
-- `--cfg vortex_nightly` (enables `portable_simd` feature gate)
 
 Everything else (build, clippy, tests, docs, benchmarks, packaging) should use stable.
 

.github/scripts/close_fixed_fuzzer_issues.py

@@ -162,7 +162,6 @@ def build_fuzz_target(target: str) -> bool:
     """Build the fuzz target once. Returns True on success."""
     print(f"\nBuilding fuzz target: {target}")
     env = os.environ.copy()
-    env["RUSTFLAGS"] = "--cfg vortex_nightly"
     result = run(
         ["cargo", "+nightly", "fuzz", "build", "--dev", "--sanitizer=none", target],
         env=env,
@@ -173,7 +172,6 @@ def build_fuzz_target(target: str) -> bool:
 def retest_crash(target: str, crash_path: str, timeout_secs: int = 120) -> str:
     """Run the fuzz target with the crash file. Returns 'fixed', 'reproduces', or 'timeout'."""
     env = os.environ.copy()
-    env["RUSTFLAGS"] = "--cfg vortex_nightly"
     try:
         result = run(
             [

.github/workflows/ci.yml

@@ -409,7 +409,7 @@ jobs:
       VORTEX_SKIP_SLOW_TESTS: "1"
       # -Cunsafe-allow-abi-mismatch=sanitizer: libraries like compiler_builtins
       # unset -Zsanitizer flag and we should allow that.
-      RUSTFLAGS: "-A warnings -Cunsafe-allow-abi-mismatch=sanitizer --cfg disable_loom --cfg vortex_nightly -C debuginfo=2 -C opt-level=0 -C strip=none"
+      RUSTFLAGS: "-A warnings -Cunsafe-allow-abi-mismatch=sanitizer -C debuginfo=2 -C opt-level=0 -C strip=none"
     steps:
       - uses: runs-on/action@v2
         if: github.repository == 'vortex-data/vortex'
@@ -492,8 +492,7 @@ jobs:
         run: |
           # TODO(myrrc): remove --no-default-features
           RUSTFLAGS="-A warnings -Cunsafe-allow-abi-mismatch=sanitizer \
-                --cfg disable_loom --cfg vortex_nightly -C debuginfo=2 \
-                -C opt-level=0 -C strip=none -Zexternal-clangrt \
+                -C debuginfo=2 -C opt-level=0 -C strip=none -Zexternal-clangrt \
                 ${{ matrix.sanitizer_flags }}" \
           cargo +$NIGHTLY_TOOLCHAIN build --locked --no-default-features \
             --target x86_64-unknown-linux-gnu -Zbuild-std \
@@ -850,7 +849,7 @@ jobs:
     timeout-minutes: 40
     env:
       MIRIFLAGS: -Zmiri-strict-provenance -Zmiri-symbolic-alignment-check -Zmiri-disable-isolation -Zmiri-env-forward=RUST_BACKTRACE
-      RUSTFLAGS: "-A warnings --cfg vortex_nightly"
+      RUSTFLAGS: "-A warnings"
       RUST_BACKTRACE: full
     steps:
       - uses: runs-on/action@v2

.github/workflows/fuzz-coverage.yml

@@ -75,8 +75,7 @@ jobs:
 
       - name: Generate coverage data
         run: |
-          RUSTFLAGS="--cfg vortex_nightly" \
-            cargo +$NIGHTLY_TOOLCHAIN fuzz coverage --release --debug-assertions \
+          cargo +$NIGHTLY_TOOLCHAIN fuzz coverage --release --debug-assertions \
             ${{ matrix.fuzz_target }} \
             -- -rss_limit_mb=4096
 

.github/workflows/fuzzer-fix-automation.yml

@@ -163,7 +163,7 @@ jobs:
           echo "Building fuzzer target: ${{ steps.extract.outputs.target }} (debug mode for faster build)"
 
           # Build the fuzzer target in debug mode (faster than release)
-          if RUSTFLAGS="--cfg vortex_nightly" cargo +$NIGHTLY_TOOLCHAIN fuzz build --dev --sanitizer=none "${{ steps.extract.outputs.target }}" 2>&1 | tee fuzzer_build.log; then
+          if cargo +$NIGHTLY_TOOLCHAIN fuzz build --dev --sanitizer=none "${{ steps.extract.outputs.target }}" 2>&1 | tee fuzzer_build.log; then
             echo "✅ Fuzzer target built successfully"
             echo "build_success=true" >> $GITHUB_OUTPUT
           else
@@ -183,7 +183,7 @@ jobs:
           echo "Attempting to reproduce crash with fuzzer (debug mode)..."
 
           # Run fuzzer with crash file (debug mode, no sanitizer, full backtrace)
-          RUSTFLAGS="--cfg vortex_nightly" RUST_BACKTRACE=full timeout 30s cargo +$NIGHTLY_TOOLCHAIN fuzz run --dev --sanitizer=none "${{ steps.extract.outputs.target }}" "${{ steps.download.outputs.crash_file_path }}" -- -runs=1 -rss_limit_mb=0 2>&1 | tee crash_reproduction.log
+          RUST_BACKTRACE=full timeout 30s cargo +$NIGHTLY_TOOLCHAIN fuzz run --dev --sanitizer=none "${{ steps.extract.outputs.target }}" "${{ steps.download.outputs.crash_file_path }}" -- -runs=1 -rss_limit_mb=0 2>&1 | tee crash_reproduction.log
 
           FUZZ_EXIT_CODE=${PIPESTATUS[0]}
 

.github/workflows/minimize_fuzz_corpus_workflow.yml

@@ -91,8 +91,7 @@ jobs:
           CORPUS_DIR="fuzz/corpus/${{ inputs.fuzz_target }}"
           MINIMIZED_DIR="${CORPUS_DIR}_minimized"
           mkdir -p "$MINIMIZED_DIR"
-          RUSTFLAGS="--cfg vortex_nightly" \
-            cargo +$NIGHTLY_TOOLCHAIN fuzz cmin $FEATURES_FLAG \
+          cargo +$NIGHTLY_TOOLCHAIN fuzz cmin $FEATURES_FLAG \
             ${{ inputs.fuzz_target }} "$CORPUS_DIR" -- "$MINIMIZED_DIR"
           rm -rf "$CORPUS_DIR"
           mv "$MINIMIZED_DIR" "$CORPUS_DIR"

.github/workflows/run-fuzzer.yml

@@ -124,7 +124,7 @@ jobs:
           if [ "${{ inputs.jobs }}" -gt 1 ]; then
             FORK_FLAG="-fork=${{ inputs.jobs }}"
           fi
-          ${{ inputs.extra_env }} RUSTFLAGS="--cfg vortex_nightly" RUST_BACKTRACE=1 \
+          ${{ inputs.extra_env }} RUST_BACKTRACE=1 \
             cargo +$NIGHTLY_TOOLCHAIN fuzz run --release --debug-assertions \
             $FEATURES_FLAG \
             ${{ inputs.fuzz_target }} -- \
@@ -163,7 +163,7 @@ jobs:
           if [ -n "${{ inputs.extra_features }}" ]; then
             FEATURES_FLAG="--features ${{ inputs.extra_features }}"
           fi
-          RUSTFLAGS="--cfg vortex_nightly" RUST_BACKTRACE=1 \
+          RUST_BACKTRACE=1 \
             cargo +$NIGHTLY_TOOLCHAIN fuzz run --release --debug-assertions \
             $FEATURES_FLAG \
             ${{ inputs.fuzz_target }} \

AGENTS.md

@@ -2,26 +2,27 @@
 
 ## Development Guidelines
 
-- project is a monorepo Rust workspace, java bindings in `/java`, python bindings in
+- Project is a monorepo Rust workspace, java bindings in `/java`, python bindings in
   `/vortex-python`
-- run `cargo build -p` to build a specific crate
-- use `cargo clippy --all-targets --all-features` to make sure a project is free of lint issues.
+- Run `cargo build -p` to build a specific crate
+- Use `cargo clippy --all-targets --all-features` to make sure a project is free of lint issues.
   Please do this every time you reach a stopping point or think you've finished work.
-- run `cargo +nightly fmt --all` to format Rust source files. Please do this every time you reach a
+- Run `cargo +nightly fmt --all` to format Rust source files. Please do this every time you reach a
   stopping point or think you've finished work.
-- run `./scripts/public-api.sh` to re-generate the public API lock files. Please do this every time
+- Run `./scripts/public-api.sh` to re-generate the public API lock files. Please do this every time
   you reach a stopping point or think you've finished work.
-- you can try running
+- You can try running
   `cargo fix --lib --allow-dirty --allow-staged && cargo clippy --fix --lib --allow-dirty --allow-staged`
   to automatically many fix minor errors.
-- when iterating on CI failures, fetch only failed job logs first
+- When iterating on CI failures, fetch only failed job logs first
   (`gh run view <run-id> --job <job-id> --log-failed`) and run narrow local repro commands for the
   affected crate/tests before running workspace-wide checks.
-- if `gh` commands fail with `error connecting to api.github.com` in sandbox, immediately rerun with
+- If `gh` commands fail with `error connecting to api.github.com` in sandbox, immediately rerun with
   escalated network permissions instead of retrying in sandbox.
-- if cargo fails with `sccache: error: Operation not permitted`, rerun the command with
-  `RUSTC_WRAPPER=` so rustc runs directly.
-- run docs doctests from the docs directory (`make -C docs doctest`) so the correct Sphinx Makefile
+- If cargo fails with `sccache: error: Operation not permitted`, rerun the command with
+  `RUSTC_WRAPPER=` so rustc runs directly. You should ONLY do this if you get this exact error, as
+  this is only a concern when you are running on our CI.
+- Run docs doctests from the docs directory (`make -C docs doctest`) so the correct Sphinx Makefile
   target is used.
 
 ## Architecture