Clippy deny absolute_paths longer than 3 elements

Signed-off-by: Robert Kruszewski <github@robertk.io>

Author: robert3005

Cargo.toml

@@ -326,6 +326,7 @@ unexpected_cfgs = { level = "deny", check-cfg = [
 warnings = "warn"
 
 [workspace.lints.clippy]
+absolute_paths = "deny"
 all = { level = "deny", priority = -1 }
 as_ptr_cast_mut = "deny"
 borrow_as_ptr = "deny"

benchmarks/datafusion-bench/src/main.rs

@@ -9,6 +9,7 @@ use clap::Parser;
 use clap::value_parser;
 use custom_labels::asynchronous::Label;
 use datafusion::arrow::array::RecordBatch;
+use datafusion::arrow::util::pretty::pretty_format_batches;
 use datafusion::common::runtime::set_join_set_tracer;
 use datafusion::datasource::listing::ListingOptions;
 use datafusion::datasource::listing::ListingTable;
@@ -26,6 +27,7 @@ use datafusion_physical_plan::collect;
 use futures::StreamExt;
 use parking_lot::Mutex;
 use tokio::fs::File;
+use vortex::io::filesystem::FileSystemRef;
 use vortex::scan::DataSourceRef;
 use vortex_bench::Benchmark;
 use vortex_bench::BenchmarkArg;
@@ -318,7 +320,7 @@ async fn register_v2_tables<B: Benchmark + ?Sized>(
             .runtime_env()
             .object_store(table_url.object_store())?;
 
-        let fs: vortex::io::filesystem::FileSystemRef = Arc::new(ObjectStoreFileSystem::new(
+        let fs: FileSystemRef = Arc::new(ObjectStoreFileSystem::new(
             Arc::clone(&store),
             SESSION.handle(),
         ));
@@ -411,7 +413,7 @@ impl BenchmarkQueryResult for DataFusionQueryResult {
     }
 
     fn display(self) -> String {
-        datafusion::arrow::util::pretty::pretty_format_batches(&self.0)
+        pretty_format_batches(&self.0)
             .map(|d| d.to_string())
             .unwrap_or_else(|e| format!("<error: {e}>"))
     }

benchmarks/lance-bench/src/main.rs

@@ -10,6 +10,7 @@ use clap::value_parser;
 use lance::datafusion::LanceTableProvider;
 use lance::dataset::Dataset;
 use lance::deps::arrow_array::RecordBatch;
+use lance::deps::datafusion::arrow::util::pretty::pretty_format_batches;
 use lance::deps::datafusion::physical_plan::ExecutionPlan;
 use lance::deps::datafusion::prelude::SessionContext;
 use lance_bench::convert::convert_parquet_to_lance;
@@ -175,7 +176,7 @@ impl BenchmarkQueryResult for LanceQueryResult {
 
     fn display(self) -> String {
         // Lance uses the same Arrow RecordBatch type
-        lance::deps::datafusion::arrow::util::pretty::pretty_format_batches(&self.0)
+        pretty_format_batches(&self.0)
             .map(|d| d.to_string())
             .unwrap_or_else(|e| format!("<error: {e}>"))
     }

clippy.toml

@@ -2,6 +2,7 @@ allow-dbg-in-tests = true
 allow-expect-in-tests = true
 allow-unwrap-in-tests = true
 allow-panic-in-tests = true
+absolute-paths-max-segments = 3
 single-char-binding-names-threshold = 2
 disallowed-types = [
     { path = "std::collections::HashMap", reason = "Use the HashMap in vortex_utils::aliases for better performance" },

encodings/alp/src/alp/compress.rs

@@ -131,6 +131,7 @@ where
 
 #[cfg(test)]
 mod tests {
+    use core::f32;
     use core::f64;
 
     use f64::consts::E;
@@ -598,8 +599,8 @@ mod tests {
     fn test_large_f32_array_with_patches() {
         let size = 5_000;
         let mut values = vec![1.5f32; size];
-        values[100] = std::f32::consts::PI;
-        values[1500] = std::f32::consts::E;
+        values[100] = f32::consts::PI;
+        values[1500] = f32::consts::E;
         values[3000] = f32::NEG_INFINITY;
         values[4500] = f32::INFINITY;
 

encodings/alp/src/alp/compute/compare.rs

@@ -150,6 +150,8 @@ where
 
 #[cfg(test)]
 mod tests {
+    use std::f32;
+
     use rstest::rstest;
     use vortex_array::ArrayRef;
     use vortex_array::LEGACY_SESSION;
@@ -321,8 +323,7 @@ mod tests {
 
     #[test]
     fn compare_with_patches() {
-        let array =
-            PrimitiveArray::from_iter([1.234f32, 1.5, 19.0, std::f32::consts::E, 1_000_000.9]);
+        let array = PrimitiveArray::from_iter([1.234f32, 1.5, 19.0, f32::consts::E, 1_000_000.9]);
         let encoded = alp_encode(
             array.as_view(),
             None,

encodings/fastlanes/src/rle/vtable/mod.rs

@@ -34,6 +34,7 @@ use vortex_session::registry::CachedId;
 use crate::RLEData;
 use crate::rle::array::INDICES_SLOT;
 use crate::rle::array::RLEArrayExt;
+use crate::rle::array::SLOT_NAMES;
 use crate::rle::array::VALUES_IDX_OFFSETS_SLOT;
 use crate::rle::array::VALUES_SLOT;
 use crate::rle::array::rle_decompress::rle_decompress;
@@ -130,7 +131,7 @@ impl VTable for RLE {
     }
 
     fn slot_name(_array: ArrayView<'_, Self>, idx: usize) -> String {
-        crate::rle::array::SLOT_NAMES[idx].to_string()
+        SLOT_NAMES[idx].to_string()
     }
 
     fn serialize(

encodings/sparse/src/compute/mod.rs

@@ -126,6 +126,8 @@ mod test {
 
 #[cfg(test)]
 mod tests {
+    use std::f32;
+
     use rstest::rstest;
     use vortex_array::IntoArray;
     use vortex_array::arrays::PrimitiveArray;
@@ -164,7 +166,7 @@ mod tests {
     ).unwrap())]
     #[case::sparse_f32(Sparse::try_new(
         buffer![2u64, 6].into_array(),
-        buffer![std::f32::consts::PI, std::f32::consts::E].into_array(),
+        buffer![f32::consts::PI, f32::consts::E].into_array(),
         8,
         Scalar::from(0.0f32)
     ).unwrap())]

vortex-array/src/aggregate_fn/fns/min_max/mod.rs

@@ -298,6 +298,7 @@ mod tests {
     use crate::aggregate_fn::EmptyOptions;
     use crate::aggregate_fn::fns::min_max::MinMax;
     use crate::aggregate_fn::fns::min_max::MinMaxResult;
+    use crate::aggregate_fn::fns::min_max::make_minmax_dtype;
     use crate::aggregate_fn::fns::min_max::min_max;
     use crate::arrays::BoolArray;
     use crate::arrays::ChunkedArray;
@@ -451,7 +452,7 @@ mod tests {
         let dtype = DType::Primitive(PType::I32, Nullability::NonNullable);
         let mut state = MinMax.empty_partial(&EmptyOptions, &dtype)?;
 
-        let struct_dtype = crate::aggregate_fn::fns::min_max::make_minmax_dtype(&dtype);
+        let struct_dtype = make_minmax_dtype(&dtype);
         let scalar1 = Scalar::struct_(
             struct_dtype.clone(),
             vec![Scalar::from(5i32), Scalar::from(15i32)],

vortex-array/src/arrays/constant/compute/mod.rs

@@ -13,6 +13,8 @@ pub(crate) mod uncompressed_size;
 
 #[cfg(test)]
 mod test {
+    use std::f64;
+
     use rstest::rstest;
 
     use crate::IntoArray;
@@ -55,7 +57,7 @@ mod test {
         5
     ))]
     // Additional test cases
-    #[case::constant_f64(ConstantArray::new(Scalar::from(std::f64::consts::PI), 10))]
+    #[case::constant_f64(ConstantArray::new(Scalar::from(f64::consts::PI), 10))]
     #[case::constant_bool(ConstantArray::new(Scalar::from(true), 7))]
     #[case::constant_single(ConstantArray::new(Scalar::from(99u64), 1))]
     #[case::constant_large(ConstantArray::new(Scalar::from("hello"), 1000))]