chore: only ignore c++ diagnostics for ddb headers (#6970)

DDB warnings to ignore need to be part of the `DUCKDB_INCLUDES_BEGIN`
macro:
```
#define DUCKDB_INCLUDES_BEGIN                                                  \
    _Pragma("GCC diagnostic push")                                             \
    _Pragma("GCC diagnostic ignored \"-Wall\"")                                \
    _Pragma("GCC diagnostic ignored \"-Wextra\"")                              \
    _Pragma("GCC diagnostic ignored \"-Wpedantic\"")                           \
    _Pragma("GCC diagnostic ignored \"-Wunused-parameter\"")                   \
    _Pragma("GCC diagnostic ignored \"-Wtype-limits\"")
#define DUCKDB_INCLUDES_END _Pragma("GCC diagnostic pop")
```

Warnings originating from our own code should simply be addressed.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>

Author: 0ax1

vortex-duckdb/build.rs

@@ -331,14 +331,7 @@ fn c2rust(crate_dir: &Path, duckdb_include_dir: &Path) {
 fn cpp(duckdb_include_dir: &Path) {
     cc::Build::new()
         .std("c++20")
-        // Duckdb sources fail -Wno-unused-parameter and -Wno-type-limits
-        .flags([
-            "-Wall",
-            "-Wextra",
-            "-Wpedantic",
-            "-Wno-unused-parameter",
-            "-Wno-type-limits",
-        ])
+        .flags(["-Wall", "-Wextra", "-Wpedantic"])
         .cpp(true)
         .include(duckdb_include_dir)
         .include("cpp/include")

vortex-duckdb/cpp/CMakeLists.txt

@@ -23,7 +23,7 @@ if (NOT CMAKE_BUILD_TYPE)
 endif()
 
 # Enable compiler warnings (matching build.rs flags).
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-type-limits")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic")
 
 # Find DuckDB include directory via the symlink created by build.rs.
 # The symlink points to target/duckdb-source-vX.Y.Z which contains duckdb-X.Y.Z/

vortex-duckdb/cpp/include/duckdb_vx/duckdb_diagnostics.h

@@ -17,10 +17,12 @@
     _Pragma("GCC diagnostic push")                                             \
     _Pragma("GCC diagnostic ignored \"-Wall\"")                                \
     _Pragma("GCC diagnostic ignored \"-Wextra\"")                              \
-    _Pragma("GCC diagnostic ignored \"-Wpedantic\"")
+    _Pragma("GCC diagnostic ignored \"-Wpedantic\"")                           \
+    _Pragma("GCC diagnostic ignored \"-Wunused-parameter\"")                   \
+    _Pragma("GCC diagnostic ignored \"-Wtype-limits\"")
 #define DUCKDB_INCLUDES_END _Pragma("GCC diagnostic pop")
 #else
 #define DUCKDB_INCLUDES_BEGIN
 #define DUCKDB_INCLUDES_END
 #endif
-// clang-format on
+// clang-format on