Skip to content

Commit a8351a9

Browse files
authored
Correctly gate zstd (#7283)
## Summary Gates `zstd` lower for schemes. Is this actually correct? Also unsure of how this actually the feature gate works with the cuda code to begin with, afaik this doesn't change any logic. ## Testing N/A Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent 017f7a7 commit a8351a9

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

vortex-btrblocks/src/builder.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ impl BtrBlocksCompressorBuilder {
143143
/// With the `unstable_encodings` feature, buffer-level Zstd compression is used which
144144
/// preserves the array buffer layout for zero-conversion GPU decompression. Without it,
145145
/// interleaved Zstd compression is used.
146-
#[cfg(feature = "zstd")]
147146
pub fn only_cuda_compatible(self) -> Self {
148147
let builder = self.exclude_schemes([
149148
integer::SparseScheme.id(),
@@ -154,9 +153,9 @@ impl BtrBlocksCompressorBuilder {
154153
string::FSSTScheme.id(),
155154
]);
156155

157-
#[cfg(feature = "unstable_encodings")]
156+
#[cfg(all(feature = "zstd", feature = "unstable_encodings"))]
158157
let builder = builder.with_new_scheme(&string::ZstdBuffersScheme);
159-
#[cfg(not(feature = "unstable_encodings"))]
158+
#[cfg(all(feature = "zstd", not(feature = "unstable_encodings")))]
160159
let builder = builder.with_new_scheme(&string::ZstdScheme);
161160

162161
builder

0 commit comments

Comments
 (0)