fix

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

encodings/alp/src/alp/compress.rs

@@ -72,7 +72,7 @@ where
     let (exponents, encoded, exceptional_positions, exceptional_values, mut chunk_offsets) =
         T::encode(values_slice, exponents);
 
-    let encoded_array = PrimitiveArray::new(encoded, values.validity().clone()).into_array();
+    let encoded_array = PrimitiveArray::new(encoded, values.validity()).into_array();
 
     let validity = values.validity_mask()?;
     // exceptional_positions may contain exceptions at invalid positions (which contain garbage

encodings/alp/src/alp/decompress.rs

@@ -100,7 +100,7 @@ fn decompress_chunked_core(
     patches: &Patches,
     dtype: DType,
 ) -> PrimitiveArray {
-    let validity = encoded.validity().clone();
+    let validity = encoded.validity();
     let ptype = dtype.as_ptype();
     let array_len = encoded.len();
     let offset_within_chunk = patches.offset_within_chunk().unwrap_or(0);
@@ -150,7 +150,7 @@ fn decompress_unchunked_core(
     dtype: DType,
     ctx: &mut ExecutionCtx,
 ) -> VortexResult<PrimitiveArray> {
-    let validity = encoded.validity().clone();
+    let validity = encoded.validity();
     let ptype = dtype.as_ptype();
 
     let decoded = match_each_alp_float_ptype!(ptype, |T| {

encodings/alp/src/alp_rd/mod.rs

@@ -228,7 +228,7 @@ impl RDEncoder {
         }
 
         // Bit-pack down the encoded left-parts array that have been dictionary encoded.
-        let primitive_left = PrimitiveArray::new(left_parts, array.validity().clone());
+        let primitive_left = PrimitiveArray::new(left_parts, array.validity());
         // SAFETY: by construction, all values in left_parts can be packed to left_bit_width.
         let packed_left = unsafe {
             bitpack_encode_unchecked(primitive_left, left_bit_width as _)

encodings/bytebool/src/array.rs

@@ -177,7 +177,7 @@ impl VTable for ByteBool {
 
     fn execute(array: Arc<Array<Self>>, _ctx: &mut ExecutionCtx) -> VortexResult<ExecutionResult> {
         let boolean_buffer = BitBuffer::from(array.as_slice());
-        let validity = array.validity().clone();
+        let validity = array.validity();
         Ok(ExecutionResult::done(
             BoolArray::new(boolean_buffer, validity).into_array(),
         ))

encodings/bytebool/src/compute.rs

@@ -28,7 +28,7 @@ impl CastReduce for ByteBool {
         if array.dtype().eq_ignore_nullability(dtype) {
             let new_validity = array
                 .validity()
-                .clone()
+                
                 .cast_nullability(dtype.nullability(), array.len())?;
 
             return Ok(Some(
@@ -48,7 +48,7 @@ impl MaskReduce for ByteBool {
                 array.buffer().clone(),
                 array
                     .validity()
-                    .clone()
+                    
                     .and(Validity::Array(mask.clone()))?,
             )
             .into_array(),

encodings/datetime-parts/src/compress.rs

@@ -52,7 +52,7 @@ pub fn split_temporal(array: TemporalArray) -> VortexResult<TemporalParts> {
     }
 
     Ok(TemporalParts {
-        days: PrimitiveArray::new(days, temporal_values.validity().clone()).into_array(),
+        days: PrimitiveArray::new(days, temporal_values.validity()).into_array(),
         seconds: seconds.into_array(),
         subseconds: subseconds.into_array(),
     })

encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs

@@ -301,7 +301,7 @@ fn to_canonical_decimal(
             DecimalArray::new_unchecked(
                 prim.to_buffer::<P>(),
                 *array.decimal_dtype(),
-                prim.validity().clone(),
+                prim.validity(),
             )
         }
         .into_array()

encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs

@@ -75,7 +75,7 @@ pub fn bitpack_encode(
         BitPackedArray::new_unchecked(
             BufferHandle::new_host(packed),
             array.dtype().clone(),
-            array.validity().clone(),
+            array.validity(),
             patches,
             bit_width,
             array.len(),
@@ -109,7 +109,7 @@ pub unsafe fn bitpack_encode_unchecked(
         BitPackedArray::new_unchecked(
             BufferHandle::new_host(packed),
             array.dtype().clone(),
-            array.validity().clone(),
+            array.validity(),
             None,
             bit_width,
             array.len(),

encodings/fastlanes/src/for/array/for_decompress.rs

@@ -57,7 +57,7 @@ pub fn decompress(array: &FoRArray, ctx: &mut ExecutionCtx) -> VortexResult<Prim
 
     // TODO(ngates): Do we need this to be into_encoded() somehow?
     let encoded = array.encoded().clone().execute::<PrimitiveArray>(ctx)?;
-    let validity = encoded.validity().clone();
+    let validity = encoded.validity();
 
     Ok(match_each_integer_ptype!(ptype, |T| {
         let min = array

encodings/fsst/src/canonical.rs

@@ -31,7 +31,7 @@ pub(super) fn canonicalize_fsst(
             views,
             Arc::from(buffers),
             array.dtype().clone(),
-            array.codes().validity().clone(),
+            array.codes().validity(),
         )
         .into_array()
     })