Skip to content

Commit ace3d8e

Browse files
authored
Fix Claude workflow cancellation (#7775)
Claude workflows cancel themselves at the moment.. Signed-off-by: Nicholas Gates <nick@nickgates.com>
1 parent 5e5572b commit ace3d8e

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

.github/workflows/claude-review.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,6 @@ name: Claude Code (Review)
1919
# - PR conversation comments on PRs already opened by the Claude App are handled by
2020
# claude-write.yml so maintainers can ask Claude to make follow-up changes there.
2121

22-
concurrency:
23-
# `issue_comment` events on PRs expose the PR number via `github.event.issue.number`,
24-
# so this falls back there when `github.event.pull_request.number` is unset.
25-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.issue.number || github.run_id }}
26-
cancel-in-progress: true
27-
2822
on:
2923
issue_comment:
3024
types: [created]
@@ -226,6 +220,11 @@ jobs:
226220
if: needs.gate.outputs.should_run == 'true'
227221
runs-on: ubuntu-latest
228222
timeout-minutes: 45
223+
concurrency:
224+
# `issue_comment` events on PRs expose the PR number via `github.event.issue.number`,
225+
# so this falls back there when `github.event.pull_request.number` is unset.
226+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.issue.number || github.run_id }}
227+
cancel-in-progress: true
229228
permissions:
230229
contents: read
231230
issues: write

.github/workflows/claude-write.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ name: Claude Code (Write)
2727
# than the numeric App ID in the PR payload, so the gate checks `CLAUDE_APP_LOGIN`
2828
# instead of comparing directly to `APP_ID`.
2929

30-
concurrency:
31-
group: ${{ github.workflow }}-${{ github.event.issue.number || github.run_id }}
32-
cancel-in-progress: true
33-
3430
on:
3531
issues:
3632
types: [opened, assigned]
@@ -152,6 +148,9 @@ jobs:
152148
if: needs.gate.outputs.should_run == 'true'
153149
runs-on: ubuntu-latest
154150
timeout-minutes: 60
151+
concurrency:
152+
group: ${{ github.workflow }}-${{ github.event.issue.number || github.run_id }}
153+
cancel-in-progress: true
155154

156155
environment:
157156
# The App private key lives only in this environment so only this single job

0 commit comments

Comments
 (0)