Skip to content

Commit ad93dcf

Browse files
committed
doc fix
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1 parent 149d652 commit ad93dcf

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

encodings/parquet-variant/src/array.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ use vortex_mask::Mask;
4545
///
4646
/// 2. **Value child nullability**: the `value` child is `Binary` and may be nullable or
4747
/// non-nullable. In partially-shredded layouts some rows have their data in `typed_value`
48-
/// instead, so the corresponding `value` slot is null — making the child nullable. This
49-
/// nullability is persisted in [`ParquetVariantMetadata::value_nullable`] so that
50-
/// serialization round-trips preserve the original Arrow field nullability.
48+
/// instead, so the corresponding `value` slot is null — making the child nullable.
5149
///
5250
/// 3. **Typed-value child nullability**: the `typed_value` child carries its own `DType`
5351
/// (which includes nullability).
@@ -98,10 +96,8 @@ impl ParquetVariantArray {
9896
"typed_value length must match metadata length"
9997
);
10098
}
101-
let nullability = match &validity {
102-
Validity::NonNullable | Validity::AllValid => Nullability::NonNullable,
103-
_ => Nullability::Nullable,
104-
};
99+
let nullability = validity.nullability();
100+
105101
Ok(Self {
106102
dtype: DType::Variant(nullability),
107103
validity,

0 commit comments

Comments
 (0)