Normalize Execution

Signed-off-by: Nicholas Gates <nick@nickgates.com>

Author: gatesn

encodings/alp/src/alp/array.rs

@@ -452,13 +452,14 @@ impl ALP {
     pub fn new(encoded: ArrayRef, exponents: Exponents, patches: Option<Patches>) -> ALPArray {
         let dtype = ALPData::logical_dtype(&encoded).vortex_expect("ALP encoded dtype");
         let len = encoded.len();
-        Array::try_from_parts(ArrayParts::new(
-            ALP,
-            dtype,
-            len,
-            ALPData::new(encoded, exponents, patches),
-        ))
-        .vortex_expect("ALPData is always valid")
+        unsafe {
+            Array::from_parts_unchecked(ArrayParts::new(
+                ALP,
+                dtype,
+                len,
+                ALPData::new(encoded, exponents, patches),
+            ))
+        }
     }
 
     pub fn try_new(
@@ -469,7 +470,7 @@ impl ALP {
         let dtype = ALPData::logical_dtype(&encoded)?;
         let len = encoded.len();
         let data = ALPData::try_new(encoded, exponents, patches)?;
-        Array::try_from_parts(ArrayParts::new(ALP, dtype, len, data))
+        Ok(unsafe { Array::from_parts_unchecked(ArrayParts::new(ALP, dtype, len, data)) })
     }
 
     /// # Safety
@@ -481,10 +482,8 @@ impl ALP {
     ) -> ALPArray {
         let dtype = ALPData::logical_dtype(&encoded).vortex_expect("ALP encoded dtype");
         let len = encoded.len();
-        Array::try_from_parts(ArrayParts::new(ALP, dtype, len, unsafe {
-            ALPData::new_unchecked(encoded, exponents, patches)
-        }))
-        .vortex_expect("ALPData is always valid")
+        let data = unsafe { ALPData::new_unchecked(encoded, exponents, patches) };
+        unsafe { Array::from_parts_unchecked(ArrayParts::new(ALP, dtype, len, data)) }
     }
 }
 

encodings/alp/src/alp_rd/array.rs

@@ -379,7 +379,11 @@ impl ALPRD {
             right_bit_width,
             left_parts_patches,
         )?;
-        Array::try_from_parts(ArrayParts::new(ALPRD, logical_dtype, len, data))
+        Ok(
+            unsafe {
+                Array::from_parts_unchecked(ArrayParts::new(ALPRD, logical_dtype, len, data))
+            },
+        )
     }
 
     /// # Safety
@@ -404,8 +408,7 @@ impl ALPRD {
                 left_parts_patches,
             )
         };
-        Array::try_from_parts(ArrayParts::new(ALPRD, logical_dtype, len, data))
-            .vortex_expect("ALPRDData is always valid")
+        unsafe { Array::from_parts_unchecked(ArrayParts::new(ALPRD, logical_dtype, len, data)) }
     }
 }
 

encodings/bytebool/src/array.rs

@@ -28,7 +28,6 @@ use vortex_array::vtable::ValidityVTableFromValidityHelper;
 use vortex_array::vtable::validity_to_child;
 use vortex_buffer::BitBuffer;
 use vortex_buffer::ByteBuffer;
-use vortex_error::VortexExpect;
 use vortex_error::VortexResult;
 use vortex_error::vortex_bail;
 use vortex_error::vortex_ensure;
@@ -189,26 +188,23 @@ impl ByteBool {
         let dtype = DType::Bool(validity.nullability());
         let data = ByteBoolData::new(buffer, validity);
         let len = data.len();
-        Array::try_from_parts(ArrayParts::new(ByteBool, dtype, len, data))
-            .vortex_expect("ByteBoolData is always valid")
+        unsafe { Array::from_parts_unchecked(ArrayParts::new(ByteBool, dtype, len, data)) }
     }
 
     /// Construct a [`ByteBoolArray`] from a `Vec<bool>` and validity.
     pub fn from_vec<V: Into<Validity>>(data: Vec<bool>, validity: V) -> ByteBoolArray {
         let data = ByteBoolData::from_vec(data, validity);
         let dtype = DType::Bool(data.validity.nullability());
         let len = data.len();
-        Array::try_from_parts(ArrayParts::new(ByteBool, dtype, len, data))
-            .vortex_expect("ByteBoolData is always valid")
+        unsafe { Array::from_parts_unchecked(ArrayParts::new(ByteBool, dtype, len, data)) }
     }
 
     /// Construct a [`ByteBoolArray`] from optional bools.
     pub fn from_option_vec(data: Vec<Option<bool>>) -> ByteBoolArray {
         let data = ByteBoolData::from(data);
         let dtype = DType::Bool(data.validity.nullability());
         let len = data.len();
-        Array::try_from_parts(ArrayParts::new(ByteBool, dtype, len, data))
-            .vortex_expect("ByteBoolData is always valid")
+        unsafe { Array::from_parts_unchecked(ArrayParts::new(ByteBool, dtype, len, data)) }
     }
 }
 

encodings/datetime-parts/src/array.rs

@@ -234,15 +234,23 @@ impl DateTimeParts {
     ) -> VortexResult<DateTimePartsArray> {
         let data = DateTimePartsData::try_new(dtype.clone(), days, seconds, subseconds)?;
         let len = data.len();
-        Array::try_from_parts(ArrayParts::new(DateTimeParts, dtype, len, data))
+        Ok(
+            unsafe {
+                Array::from_parts_unchecked(ArrayParts::new(DateTimeParts, dtype, len, data))
+            },
+        )
     }
 
     /// Construct a [`DateTimePartsArray`] from a [`TemporalArray`].
     pub fn try_from_temporal(temporal: TemporalArray) -> VortexResult<DateTimePartsArray> {
         let dtype = temporal.dtype().clone();
         let data = DateTimePartsData::try_from(temporal)?;
         let len = data.len();
-        Array::try_from_parts(ArrayParts::new(DateTimeParts, dtype, len, data))
+        Ok(
+            unsafe {
+                Array::from_parts_unchecked(ArrayParts::new(DateTimeParts, dtype, len, data))
+            },
+        )
     }
 }
 

encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs

@@ -266,7 +266,9 @@ impl DecimalByteParts {
         let data = DecimalBytePartsData::try_new(msp, decimal_dtype)?;
         let dtype = DType::Decimal(decimal_dtype, data.msp().dtype().nullability());
         let len = data.len();
-        Array::try_from_parts(ArrayParts::new(DecimalByteParts, dtype, len, data))
+        Ok(unsafe {
+            Array::from_parts_unchecked(ArrayParts::new(DecimalByteParts, dtype, len, data))
+        })
     }
 }
 

encodings/fastlanes/public-api.lock

@@ -78,15 +78,15 @@ pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, S>::decode_into(&mut sel
 
 pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, S>::initial(&mut self) -> core::option::Option<&mut [T]>
 
-pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, S>::new_with_strategy(strategy: S, packed: vortex_buffer::ByteBuffer, bit_width: usize, offset: usize, len: usize) -> Self
-
 pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, S>::trailer(&mut self) -> core::option::Option<&mut [T]>
 
+pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, S>::try_new_with_strategy(strategy: S, packed: vortex_buffer::ByteBuffer, bit_width: usize, offset: usize, len: usize) -> vortex_error::VortexResult<Self>
+
 impl<T: vortex_fastlanes::unpack_iter::BitPacked> vortex_fastlanes::unpack_iter::UnpackedChunks<T, vortex_fastlanes::unpack_iter::BitPackingStrategy>
 
 pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, vortex_fastlanes::unpack_iter::BitPackingStrategy>::full_chunks(&mut self) -> vortex_fastlanes::unpack_iter::BitUnpackIterator<'_, T>
 
-pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, vortex_fastlanes::unpack_iter::BitPackingStrategy>::new(array: &vortex_fastlanes::BitPackedData, len: usize) -> Self
+pub fn vortex_fastlanes::unpack_iter::UnpackedChunks<T, vortex_fastlanes::unpack_iter::BitPackingStrategy>::try_new(array: &vortex_fastlanes::BitPackedData, len: usize) -> vortex_error::VortexResult<Self>
 
 pub trait vortex_fastlanes::unpack_iter::BitPacked: vortex_array::dtype::ptype::PhysicalPType<Physicalfastlanes::bitpacking::BitPacking>
 
@@ -218,6 +218,12 @@ pub fn vortex_fastlanes::BitPackedData::packed(&self) -> &vortex_array::buffer::
 
 pub fn vortex_fastlanes::BitPackedData::packed_slice<T: vortex_array::dtype::ptype::NativePType + fastlanes::bitpacking::BitPacking>(&self) -> &[T]
 
+pub fn vortex_fastlanes::BitPackedData::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedData::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedData::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
 pub fn vortex_fastlanes::BitPackedData::patches(&self, len: usize) -> core::option::Option<vortex_array::patches::Patches>
 
 pub fn vortex_fastlanes::BitPackedData::ptype(&self, dtype: &vortex_array::dtype::DType) -> vortex_array::dtype::ptype::PType
@@ -226,10 +232,12 @@ pub fn vortex_fastlanes::BitPackedData::replace_patches(&mut self, patches: core
 
 pub fn vortex_fastlanes::BitPackedData::try_new(packed: vortex_array::buffer::BufferHandle, ptype: vortex_array::dtype::ptype::PType, validity: vortex_array::validity::Validity, patches: core::option::Option<vortex_array::patches::Patches>, bit_width: u8, length: usize, offset: u16) -> vortex_error::VortexResult<Self>
 
-pub fn vortex_fastlanes::BitPackedData::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self, dtype: &vortex_array::dtype::DType, len: usize) -> vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>
+pub fn vortex_fastlanes::BitPackedData::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self, dtype: &vortex_array::dtype::DType, len: usize) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
 
 pub fn vortex_fastlanes::BitPackedData::validity(&self, nullability: vortex_array::dtype::nullability::Nullability) -> vortex_array::validity::Validity
 
+pub fn vortex_fastlanes::BitPackedData::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
 pub fn vortex_fastlanes::BitPackedData::validity_mask(&self, len: usize, nullability: vortex_array::dtype::nullability::Nullability) -> vortex_mask::Mask
 
 impl core::clone::Clone for vortex_fastlanes::BitPackedData
@@ -558,6 +566,102 @@ impl core::fmt::Debug for vortex_fastlanes::RLEData
 
 pub fn vortex_fastlanes::RLEData::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
 
+pub trait vortex_fastlanes::BitPackedArrayExt
+
+pub fn vortex_fastlanes::BitPackedArrayExt::bit_width(&self) -> u8
+
+pub fn vortex_fastlanes::BitPackedArrayExt::bitpacked_data(&self) -> &vortex_fastlanes::BitPackedData
+
+pub fn vortex_fastlanes::BitPackedArrayExt::bitpacked_dtype(&self) -> &vortex_array::dtype::DType
+
+pub fn vortex_fastlanes::BitPackedArrayExt::bitpacked_len(&self) -> usize
+
+pub fn vortex_fastlanes::BitPackedArrayExt::offset(&self) -> u16
+
+pub fn vortex_fastlanes::BitPackedArrayExt::packed(&self) -> &vortex_array::buffer::BufferHandle
+
+pub fn vortex_fastlanes::BitPackedArrayExt::packed_slice<T: vortex_array::dtype::ptype::NativePType + fastlanes::bitpacking::BitPacking>(&self) -> &[T]
+
+pub fn vortex_fastlanes::BitPackedArrayExt::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArrayExt::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArrayExt::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArrayExt::patches(&self) -> core::option::Option<vortex_array::patches::Patches>
+
+pub fn vortex_fastlanes::BitPackedArrayExt::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
+
+pub fn vortex_fastlanes::BitPackedArrayExt::validity(&self) -> vortex_array::validity::Validity
+
+pub fn vortex_fastlanes::BitPackedArrayExt::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_fastlanes::BitPackedArrayExt::validity_mask(&self) -> vortex_mask::Mask
+
+impl vortex_fastlanes::BitPackedArrayExt for vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::bit_width(&self) -> u8
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::bitpacked_data(&self) -> &vortex_fastlanes::BitPackedData
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::bitpacked_dtype(&self) -> &vortex_array::dtype::DType
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::bitpacked_len(&self) -> usize
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::offset(&self) -> u16
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::packed(&self) -> &vortex_array::buffer::BufferHandle
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::packed_slice<T: vortex_array::dtype::ptype::NativePType + fastlanes::bitpacking::BitPacking>(&self) -> &[T]
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::patches(&self) -> core::option::Option<vortex_array::patches::Patches>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::validity(&self) -> vortex_array::validity::Validity
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::typed::Array<vortex_fastlanes::BitPacked>::validity_mask(&self) -> vortex_mask::Mask
+
+impl vortex_fastlanes::BitPackedArrayExt for vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::bit_width(&self) -> u8
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::bitpacked_data(&self) -> &vortex_fastlanes::BitPackedData
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::bitpacked_dtype(&self) -> &vortex_array::dtype::DType
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::bitpacked_len(&self) -> usize
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::offset(&self) -> u16
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::packed(&self) -> &vortex_array::buffer::BufferHandle
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::packed_slice<T: vortex_array::dtype::ptype::NativePType + fastlanes::bitpacking::BitPacking>(&self) -> &[T]
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::patch_chunk_offsets(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::patch_indices(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::patch_values(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::patches(&self) -> core::option::Option<vortex_array::patches::Patches>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::unpacked_chunks<T: vortex_fastlanes::unpack_iter::BitPacked>(&self) -> vortex_error::VortexResult<vortex_fastlanes::unpack_iter::BitUnpackedChunks<T>>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::validity(&self) -> vortex_array::validity::Validity
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::validity_child(&self) -> core::option::Option<&vortex_array::array::erased::ArrayRef>
+
+pub fn vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>::validity_mask(&self) -> vortex_mask::Mask
+
 pub fn vortex_fastlanes::delta_compress(array: &vortex_array::arrays::primitive::vtable::PrimitiveArray, ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<(vortex_array::arrays::primitive::vtable::PrimitiveArray, vortex_array::arrays::primitive::vtable::PrimitiveArray)>
 
 pub fn vortex_fastlanes::initialize(session: &mut vortex_session::VortexSession)